Closed Bug 78745 Opened 24 years ago Closed 24 years ago

nsIPromptService::ConfirmEx needs to be more flexible.

Categories

(Core Graveyard :: Embedding: APIs, defect)

defect
Not set
critical

Tracking

(Not tracked)

VERIFIED FIXED
mozilla0.9.1

People

(Reporter: ccarlen, Assigned: ccarlen)

Details

Attachments

(2 files)

This was spawned from bug 77684. Currently, only 1 button of confirmEx can be specified as a string. This limits the UI. I want to make custom button titles available to any button as well as still be able to use the IDL defined constants. Patch coming up.
Attached patch API change to confirmEx (deleted) — Splinter Review
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.1
Attached patch tree-wide diffs (deleted) — Splinter Review
Here's the patch. A few things: (1) The viewer app contained two implementations of nsIPrompt - neither of which can be used. So, instead of patching those, I just removed the prompt impls. (2) This will fix bug 77684. While visting that confirmEx call site, I put back the original button text. (3) After asking Adam, the activex control also has an nsIPrompt impl which is unreachable. Although it is not removed in this patch. I will remove it. Jud, Blake - can you review? UI folks - speak now :-)
r=valeski
CC'ing Simon for sr.
sr=sfraser
Conrad, thanks for going the extra mile and doing this!
Keywords: patch
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
I like the new wording, verifying fixed
Status: RESOLVED → VERIFIED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: