Closed
Bug 78745
Opened 24 years ago
Closed 24 years ago
nsIPromptService::ConfirmEx needs to be more flexible.
Categories
(Core Graveyard :: Embedding: APIs, defect)
Core Graveyard
Embedding: APIs
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla0.9.1
People
(Reporter: ccarlen, Assigned: ccarlen)
Details
Attachments
(2 files)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review |
This was spawned from bug 77684. Currently, only 1 button of confirmEx can be
specified as a string. This limits the UI. I want to make custom button titles
available to any button as well as still be able to use the IDL defined
constants. Patch coming up.
Assignee | ||
Comment 1•24 years ago
|
||
Assignee | ||
Updated•24 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.1
Assignee | ||
Comment 2•24 years ago
|
||
Assignee | ||
Comment 3•24 years ago
|
||
Here's the patch. A few things:
(1) The viewer app contained two implementations of nsIPrompt - neither of which
can be used. So, instead of patching those, I just removed the prompt impls.
(2) This will fix bug 77684. While visting that confirmEx call site, I put back
the original button text.
(3) After asking Adam, the activex control also has an nsIPrompt impl which is
unreachable. Although it is not removed in this patch. I will remove it.
Jud, Blake - can you review?
UI folks - speak now :-)
Comment 4•24 years ago
|
||
r=valeski
Assignee | ||
Comment 5•24 years ago
|
||
CC'ing Simon for sr.
Comment 6•24 years ago
|
||
sr=sfraser
Comment 7•24 years ago
|
||
Conrad, thanks for going the extra mile and doing this!
Assignee | ||
Comment 8•24 years ago
|
||
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•