On bug 75924, I wrote: ----- I also had to make inspector link against gkgfx and libgkconshared_s to fix AIX bustage. The latter dependency really has to go. The errors that led me to do that were: ld: 0711-317 ERROR: Undefined symbol: .NS_HexToRGB ld: 0711-317 ERROR: Undefined symbol: .nsCSSProps::AddRefTable() ld: 0711-317 ERROR: Undefined symbol: .nsCSSProps::ReleaseTable() ld: 0711-317 ERROR: Undefined symbol: .nsCSSProps::GetStringValue(nsCSSProperty) ld: 0711-317 ERROR: Undefined symbol: .nsCSSProps::LookupProperty(const nsAString&) (I wonder why it was linking against rdfutil_s to begin with... that would be good to remove as well.) ----- I'm filing this bug as a request to fix these dependencies. It would be good to do this before turning inspector on by default.

mac cfm build has duplicated files (!!) to fix the build errors, and mac mach-o just plain doesn't link. Why is this cleanup scheduled for 'future'?

FYI Bug 107270 checkin caused mac build bustage due to this problem. More bogus files added to mac inspector project to get to build. Many libs added to makefile.win to get around this problem. Just saying "there is still pain, and this needs to get solved"

I'd appreciate if someone could test this on Windows and on mach-o/gcc.

Does this patch seem reasonable? Can someone think of a name better than InspectorCSSUtils?

CSSNodeInspector ?

We want this, we do *not* want to turn inspector off in default builds -- it's too useful (even if hewitt is indifferent to all his fans :-). Cc'ing Marc for help reviewing. Let's get this in for 0.9.9, otherwise inspector is out of default builds for 1.0. /be

Comment on attachment 69706 [details] [diff] [review] proposed patch r=beard Patch works for me.

Taking.

Comment on attachment 69706 [details] [diff] [review] proposed patch sr=shaver, but I want to see a review from a layout owner or peer before it goes in. (Unmarking has-review only because there's no other way to indicate "waiting for review", and not as a snub to beard!)

Comment on attachment 69706 [details] [diff] [review] proposed patch r=attinasi

This looks great to me. Thanks for the help, David.

Fix checked in 2002-02-18 18:09 PST.

Thank you very much dbaron! I'm really hoping DOM Inspector makes it in for 1.0

v.