Closed
Bug 791378
Opened 12 years ago
Closed 12 years ago
nsPluginHost::NewPluginURLStream needs to take the privacy information into account when creating a channel on behalf of a plugin
Categories
(Core Graveyard :: Plug-ins, defect)
Tracking
(Not tracked)
RESOLVED
INVALID
mozilla18
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
|
Assignee | |
Comment 1•12 years ago
|
||
|
||
Comment 2•12 years ago
|
||
Comment on attachment 661373 [details] [diff] [review]
Patch (v1)
r=me, but this channel not being in a loadgroup is complete bullshit. :( Reading bug 166613 comment 20 makes me want to punch a wall or something...
Attachment #661373 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Target Milestone: --- → mozilla18
|
|
Assignee | |
Comment 4•12 years ago
|
||
So after some testing, it seems like we can actually get an nsILoadContext* out of the channel's callback (and nsPluginStreamListenerPeer). So I don't think my patch here is necessary at all (and it indeed fatally asserts in PrivateBrowsingChannel::SetPrivate).
So, I backed this out <https://hg.mozilla.org/integration/mozilla-inbound/rev/a9c81707652a> and will mark this bug as INVALID.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → INVALID
|
||
Comment 5•12 years ago
|
||
|
||
Updated•3 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•