Closed
Bug 79201
Opened 24 years ago
Closed 24 years ago
|already_AddRefed| needs non-|const| version of |.get()| for broken compilers
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
INVALID
People
(Reporter: scc, Assigned: scc)
Details
Attachments
(1 file)
(deleted),
patch
|
Details | Diff | Splinter Review |
...(as discovered by Leif Hedstrom) now that the fix for bug #75504 has made
|.get()| a requirement when assigning an |already_AddRefed| result into a raw
pointer.
Assignee | ||
Comment 1•24 years ago
|
||
Assignee | ||
Comment 2•24 years ago
|
||
looking to leif for r= and brendan for sr=; I'll send mail as well
Assignee | ||
Comment 3•24 years ago
|
||
According to Leif:
>Hmmmm, this might be false alarm... :( I had an older version of the
>nsCOMPtr.h in my Linux directory, but the latest in the Macintosh build.
>Let me test it again, I bet this patch is not needed, and that my gcc
>will pick up the "const" version of .get().
If so, I will invalidate this bug.
Comment 4•24 years ago
|
||
Just pulled a fresh tree, and rebuilt using the old version of the service
(using |already_AddRefed| and |.get()|), and things work on Linux _without_ this
patch. I haven't tested it on Mac again, but I believe you can mark this as
INVALID.
Do you guys think I should revert back to that old version of nsLDAPService
again?
Sorry for the confusion.
Assignee | ||
Comment 5•24 years ago
|
||
I think you should exploit |already_AddRefed| where possible. It'll save
trouble later.
Marking this bug INVALID as per your investigation. Thanks again for your help :-)
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•