Categories
(Core :: Networking, defect, P5)
Core
Networking
Tracking
()
RESOLVED
WONTFIX
mozilla0.9.4
People
(Reporter: benc, Unassigned)
References
Details
(Whiteboard: [necko-would-take])
Regarding deprecated function, here is implementation of weekdayRange():
------------------------------------------------------
var date = new Date();
var wdays = new Array("SUN", "MON", "TUE", "WED", "THU", "FRI", "SAT");
function weekdayRange() {
function getDay(weekday) {
for (var i = 0; i < 6; i++) {
if (weekday == wdays[i])
return i;
}
return -1;
}
var argc = arguments.length;
var wday;
if (argc < 1)
return false;
if (arguments[argc - 1] == "GMT") {
argc--;
wday = date.getUTCDay();
} else {
wday = date.getDay();
}
var wd1 = getDay(arguments[0]);
var wd2 = (argc == 2) ? getDay(arguments[1]) : wd1;
return (wd1 == -1 || wd2 == -1) ? false
: (wd1 <= wday && wday <= wd2);
}
qa to me
depends on 53080
Comment 3•23 years ago
|
||
Serge, can you take a look at these PAC issues? Thanks - Jussi-Pekka
Assignee: jpm → serge
Comment 4•23 years ago
|
||
Doesn't look like this is getting fixed before the freeze tonight.
Pushing out a milestone. Please correct if I'm mistaken.
Target Milestone: mozilla0.9.3 → mozilla0.9.4
Comment 5•23 years ago
|
||
I can't figure out what this bug is about -- the implementation given in the
summary went in as part of the PAC overhaul. weekdayRange() is apparently
deprecated, but I assume that doesn't mean we're going to rip it out again.
I smell an easy resolution. cc'ing gagan in case he knows something I don't.
I filed it because I was trying to rip all issues out of the bugs that had
morphed into many-headed hydras.
If it works and it's in, we are good.
Comment 7•23 years ago
|
||
I did some basic testing to make sure that it behaves, and everything seems ok.
Marking FIXED.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
REOPEN: (Since there is only one bug in the history of this function...)
I've been writing a whitebox/harness test for this function, and found the following:
1- The number of arguments is not properly enforced because after GMT is stripped, the number of arguments is not enforced.
2- The wrap-around date is not supported.
Status: RESOLVED → REOPENED
QA Contact: pacqa → benc
Resolution: FIXED → ---
Updated•9 years ago
|
Summary: PAC: weekdayRange() → PAC: weekdayRange() see comment 8
Whiteboard: [necko-would-take]
Comment 9•7 years ago
|
||
Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258
Priority: -- → P5
Updated•3 years ago
|
Assignee: srgchrpv → nobody
Updated•2 years ago
|
Severity: normal → S3
Comment 10•2 years ago
|
||
I think at this point behaviour is well documented [1] and Chrome has the same implementation [2] as Firefox [3]
[1] https://developer.mozilla.org/en-US/docs/Web/HTTP/Proxy_servers_and_tunneling/Proxy_Auto-Configuration_PAC_file#weekdayrange
[2] https://source.chromium.org/chromium/chromium/src/+/main:services/proxy_resolver/pac_js_library.h;l=128;drc=098756533733ea50b2dcb1c40d9a9e18d49febbe
[3] https://searchfox.org/mozilla-central/rev/2ce39261ea6a69e49d87f76a119494b2a7a7e42a/netwerk/base/ascii_pac_utils.js#96
Status: REOPENED → RESOLVED
Closed: 23 years ago → 2 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•