If you simply add a link to a panel, then on osx that will look like a dark blue link on a black background, which is horrible. The default theme should look pretty.

Slight change to anchor color and typeface (nothing else in Firefox has a serif font) Currently/before: http://grab.by/w4Mg With patch/after: http://grab.by/w4Me

Pinging you two for a review on what is beauty.

Comment on attachment 8407187 [details] GH PR 1460 Hmm I don't think we should make the `<a>` color black by default, also I'm not sure why I said the default background color is black, as it appears to be white in your screenshot. I should have added an example and screenshot.. The font change looks alright to me, it should have a test though too if Matteo agrees with the change.

(In reply to Erik Vold [:erikvold] [:ztatic] from comment #3) > Hmm I don't think we should make the `<a>` color black by default, also I'm > not sure why I said the default background color is black, as it appears to > be white in your screenshot. In the past, OS X used to have black panels, that's why. And the default blue color of the links what honestly something terrible to see. I think that now, with bright panel, we can leave the default color as is, and just modify the font. > The font change looks alright to me, it should have a test though too if > Matteo agrees with the change. Yes, let's change the font but not the link color. However, we shouldn't hard code the font, but use the default ones – it seems in fact that the font on OS X for panel is Lucida Grande, not Helvetica. I would suggest a similar approach we did for color, so get the default one and apply. Something similar we did for Widget's font too: https://github.com/mozilla/addon-sdk/pull/352/files (without `textShadow` in panel's case)

Updated PR to only affect the typeface (that's inherited from the default), but I'll still contest having blue/purple links are hideous :p

(In reply to Jordan Santell [:jsantell] [@jsantell] from comment #5) > Updated PR to only affect the typeface (that's inherited from the default), > but I'll still contest having blue/purple links are hideous :p They're not optimal maybe, but at least they're readable / usable compare to the previous situation – on dark background was a "punch in the eye", as we say in Italian ;) I don't think it's a big issue, I believe that if you create a HTML <a> tag in Firefox UI you will probably end up with the same default color we have in the panel. I think we can land this patch as is, and then file a new bug for that; or, if you are not in rush, we can leave this one open and asking to UX how the default link color should be.

Adding font weight/size in OSX looks grand -- w/r/t the colouring of the anchors, maybe we should have that in a new PR, or talk to Darrin about it, and other UX stuff, regarding the SDK

(In reply to Jordan Santell [:jsantell] [@jsantell] from comment #7) > Adding font weight/size in OSX looks grand -- w/r/t the colouring of the > anchors, maybe we should have that in a new PR, or talk to Darrin about it, > and other UX stuff, regarding the SDK Sounds good to me.

Commits pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/1e6a9dbf47f3a2b119825a486e05d80bc1a1c2e2 Bug 793413 - Use sans-serif typefaces in panel https://github.com/mozilla/addon-sdk/commit/e0db93b387630bf81fc7796bd56d72715064f2a2 Merge pull request #1460 from jsantell/793413-pretty-panels Bug 793413 - Use inherited type face, font weight and size in panels, r=@ZER0