The space bar does not activate a button when pressed over a button with the focus. This is important for keyboard navigation in my opinion. 0.8.1 still had this functionality, 0.9 and todays nightly (build id 200105089 do not. Steps to reproduce: 1) go to http://www.google.de 2) press tab to give the "Google-Suche" (german for google search) button the focus 3) press space 4) nothing happens Keep up the good work, guys!

This is unfortunately a recent regression.... Thanks for using Mozilla and reporting bugs! *** This bug has been marked as a duplicate of 53896 ***

v

Let's leave this open. That other bug has been open for so long, and was only really for the scrolling problem. Now it no longer scrolls, but no longer works either.

Cc'ing Rod, but I'd guess this is Arik since it's all broken for other form elements (e.g. checkboxes).

*** Bug 79530 has been marked as a duplicate of this bug. ***

catfood based on all the noise about this being in 0.9

Aw, come on - I was first in 79253! Just kidding. cc: me.

Arik, what's going on with this?

p2/0.9.1, probably need to take on 0.9 branch too, if broken there. please add ETA dates to status whiteboard.

not sick anymore. will get on this asap. will update whiteboard rsn.

hmm, afaict the problem here isn't that my change broke the command working but that atm the focused element is not correct, the buttons and checkboxes are not being considered focused when the outline is on them but one or more tabs later. don't think i broke this but i will do a local revert to make sure. either way i wonder what is causing this...?

*** Bug 80673 has been marked as a duplicate of this bug. ***

*** Bug 80908 has been marked as a duplicate of this bug. ***

yes, the current focused content in the EventStateManager is incorrect. I have a simple form example with a submit button and for some reason a "box" frame has focus.

A long shot, but any chance this is related to bug 81115?

could be related, i need to look into all of this, i am making progress on the bug.

ok i think i know what is going on here, should have a first crack at a patch (and an explanation) later tonight

well i do (sorta) know what's going on, i did in fact cause this by my move of the js spacebar code into the c++, somehow the c++ code is getting the wrong active element, asked saari for help as my focus knowledge is in no way extensive.

ok, so i moved my code to before the code that prevents default actions from happening which was stopping the action from taking place. the bit about the wrong element being focused appears to have been incorrect, anyway seeking r= and sr= ;-)

Yes, that looks right. sr=hyatt

commited on trunk, need a= for 0.9

Works on Win32 - 2001051908.

Whoops, I spoke too soon. If pressing the button causes the password manager dialog to come up ("Save this password?" Yes/Never/No), the Yes button is automatically pressed. Try this at hotmail.com, my.netscape.com, bugzilla login page, etc.

what? ok i will try this out... damnit...

just tested with my build from last night and it works fine on linux at least...

That's bug 68846; it existed before this fix. Reclosing.

need to get into 0.9, not closed yet...

Really?? I've never run into this before, and I run on nothing but nightlies, but I guess it's all contained in 68846. Maybe I just haven't gone to a login site since February, but I'm pretty sure I have.

0.9 is closed. drivers said nothing is being checked in to that branch which means...

vrfy fixed using 2001.05.24.0x comm bits on winnt and mac, and an 8pm [5/24] moz debug on linux.