Closed
Bug 79502
Opened 24 years ago
Closed 23 years ago
PAC: isPlainHostName not working
Categories
(Core :: Networking, defect)
Core
Networking
Tracking
()
VERIFIED
FIXED
People
(Reporter: bnb, Assigned: srgchrpv)
References
Details
(Keywords: relnote, Whiteboard: checkwin, checklinux)
Attachments
(3 files)
(deleted),
text/plain
|
Details | |
(deleted),
text/plain
|
Details | |
(deleted),
patch
|
Details | Diff | Splinter Review |
In an autoproxy config isPlainHostName(host) doesn't return true for the
hostname "intranet" while !shExpMatch(host,".") does.
Comment 4•23 years ago
|
||
marking NEW.
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: other → All
Hardware: PC → All
Summary: isPlainHostName just plain doesn't work!! → PAC: isPlainHostName just plain doesn't work!!
Updated•23 years ago
|
Comment 6•23 years ago
|
||
Comment 7•23 years ago
|
||
Not that I actually know javascript :), but this code is being evaluated twice;
hence it needs to be doubly escaped. I gave this a spin and it appeared to work.
Comment 8•23 years ago
|
||
Bug owner, can you review tingley@sundell.net's patch when you get a chance please?
Comment 9•23 years ago
|
||
Serge, can you take a look at these PAC issues? Thanks - Jussi-Pekka
Assignee: jpm → serge
Assignee | ||
Updated•23 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 10•23 years ago
|
||
yes, that is correct, it needs to be doubly escaped,
because of double evaluation;
r=serge.
Summary: PAC: isPlainHostName just plain doesn't work!! → PAC: isPlainHostName not working
Comment 11•23 years ago
|
||
sr=rpotts
Comment 12•23 years ago
|
||
Can anyone check this in for me? Thanks.
Whiteboard: have r=,sr=; needs checkin
Assignee | ||
Comment 13•23 years ago
|
||
I'll do so. Thanks
Comment 14•23 years ago
|
||
is this checked in?
Assignee | ||
Comment 15•23 years ago
|
||
done
new revision: 1.11;
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Comment 17•21 years ago
|
||
VERIFIED:
in the soon-to-be posted PAC unit tests, you will be able to use
isPlainHostName.pac to verify this function works.
Status: RESOLVED → VERIFIED
Keywords: verifyme
Whiteboard: have r=,sr=; needs checkin → checkwin, checklinux
You need to log in
before you can comment on or make changes to this bug.
Description
•