Closed Bug 79502 Opened 24 years ago Closed 23 years ago

PAC: isPlainHostName not working

Categories

(Core :: Networking, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED

People

(Reporter: bnb, Assigned: srgchrpv)

References

Details

(Keywords: relnote, Whiteboard: checkwin, checklinux)

Attachments

(3 files)

In an autoproxy config isPlainHostName(host) doesn't return true for the hostname "intranet" while !shExpMatch(host,".") does.
qa to me.
QA Contact: tever → benc
marking NEW.
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: other → All
Hardware: PC → All
Summary: isPlainHostName just plain doesn't work!! → PAC: isPlainHostName just plain doesn't work!!
PAC bugs to jpm
Assignee: neeti → jpm
Blocks: 85656, 86856
Blocks: 84647
Blocks: 79893
Blocks: 87272
Attached patch patch (deleted) — Splinter Review
Not that I actually know javascript :), but this code is being evaluated twice; hence it needs to be doubly escaped. I gave this a spin and it appeared to work.
Bug owner, can you review tingley@sundell.net's patch when you get a chance please?
QA Contact: benc → pacqa
Serge, can you take a look at these PAC issues? Thanks - Jussi-Pekka
Assignee: jpm → serge
Keywords: patch
Status: NEW → ASSIGNED
yes, that is correct, it needs to be doubly escaped, because of double evaluation; r=serge.
Summary: PAC: isPlainHostName just plain doesn't work!! → PAC: isPlainHostName not working
sr=rpotts
Can anyone check this in for me? Thanks.
Whiteboard: have r=,sr=; needs checkin
I'll do so. Thanks
is this checked in?
done new revision: 1.11;
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
+relnote & making test: need to relnote if not working.
VERIFIED: in the soon-to-be posted PAC unit tests, you will be able to use isPlainHostName.pac to verify this function works.
Status: RESOLVED → VERIFIED
Keywords: verifyme
Whiteboard: have r=,sr=; needs checkin → checkwin, checklinux
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: