Closed
Bug 795711
Opened 12 years ago
Closed 12 years ago
Setting network.activity.blipIntervalMilliseconds in the user pref should make network blip notifications being sent
Categories
(Core :: Networking, defect)
Core
Networking
Tracking
()
People
(Reporter: mounir, Assigned: mounir)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
Right now, if network.activity.blipIntervalMilliseconds is set as a user_pref(), it does nothing. The only way to have the value taken into consideration is to have it set as a pref(). Unfortunately, this prevents tests for bug 795136 to run.
|
Assignee | |
Comment 1•12 years ago
|
||
This should block because it prevents us from testing the feature.
blocking-basecamp: --- → ?
|
|
Assignee | |
Comment 2•12 years ago
|
||
This patch makes us wait for the profile to be read before starting the network montioring. That way, we can read the user pref.
|
||
Comment 3•12 years ago
|
||
Comment on attachment 666332 [details] [diff] [review]
Patch
r=me
Attachment #666332 -
Flags: review?(michal.novotny) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
Sent to try with other patches:
https://tbpl.mozilla.org/?tree=Try&rev=6a6690d20239
|
|
Assignee | |
Comment 5•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/c7df09766614
This is going to be tested by bug 795716.
Target Milestone: --- → mozilla18
|
||
Updated•12 years ago
|
blocking-basecamp: ? → +
|
||
Comment 6•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c7df09766614
Should this have a test?
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•