Comment on attachment 667962 [details] [diff] [review] patch Can you make the initialization of UserAgentOverrides conditional on the presence of general.useragent.override.* prefs, rather than commenting them out like that? How did you determine that this was fixed?

(In reply to :Gavin Sharp (use gavin@gavinsharp.com for email) from comment #2) > How did you determine that this was fixed? Look here https://bugzilla.mozilla.org/show_bug.cgi?id=778408#c16

(In reply to :Gavin Sharp (use gavin@gavinsharp.com for email) from comment #2) > Comment on attachment 667962 [details] [diff] [review] > patch > > Can you make the initialization of UserAgentOverrides conditional on the > presence of general.useragent.override.* prefs, rather than commenting them > out like that? Where? In nsBrowserGlue? In the jsm? Initializing the module without any prefs set is a reasonable thing to do, since the module will monitor the pref branch for live modifications. I just thought we'd rather avoid the tiny overhead, but other consumers might decide differently. > How did you determine that this was fixed? I logged in with a dummy AOL mail account.

(In reply to Dão Gottwald [:dao] from comment #4) > Where? In nsBrowserGlue? In the jsm? Initializing the module without any > prefs set is a reasonable thing to do, since the module will monitor the > pref branch for live modifications. I just thought we'd rather avoid the > tiny overhead, but other consumers might decide differently. I meant in nsBrowserGlue. I don't think we need to support live modifications to these prefs at all, really.

This override isn't the last one anymore, so I'm simply removing the pref and leaving the initialization alone.

Comment on attachment 669936 [details] [diff] [review] patch [Approval Request Comment] Bug caused by (feature/regressing bug #): bug 778408 (tech evangelism made this override unnecessary) User impact if declined: we expect AOL mail to work either way Testing completed (on m-c, etc.): on m-c Risk to taking this patch (and alternatives if risky): low risk String or UUID changes made by this patch: none

https://hg.mozilla.org/releases/mozilla-aurora/rev/6c938992407a https://hg.mozilla.org/releases/mozilla-beta/rev/608df791629c