Closed
Bug 79780
Opened 24 years ago
Closed 23 years ago
remove checkbox "Use the addressbook and do not search in the directory"
Categories
(MailNews Core :: LDAP Integration, defect, P2)
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla0.9.2
People
(Reporter: yulian, Assigned: srilatha)
References
Details
(Whiteboard: Have a fix, r=, need an sr=)
Attachments
(3 files)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review |
Build ID: 2001050904
In Prefs, check for "Use the address and do not search in the directory"
if there is a match in your local address books. Still do search in the directory.
Assignee | ||
Updated•24 years ago
|
Priority: -- → P2
Target Milestone: --- → mozilla0.9.2
Assignee | ||
Comment 1•24 years ago
|
||
To make this work, we need to tweak into the autocomplete widget, and I am not
sure if we can finish this in the time we have. So, I am going to disable this
checkbox for now.
Component: Address Book → LDAP Mail/News Integration
Assignee | ||
Comment 2•24 years ago
|
||
Assignee | ||
Comment 3•24 years ago
|
||
Will enable the checkbox, when I have the patch. I think the checkbox being
diabled will be less confusing to the user than it being enabled and not work.
Comment 4•24 years ago
|
||
r=mohanb;
Assignee | ||
Comment 5•24 years ago
|
||
Changed summary.
ccin Seth for sr
Summary: Search in the directory even there is a match in local address book → disable checkbox "Use the addressbook and do not search in the directory"
Whiteboard: Have a fix, r=, need an sr=
Comment 6•24 years ago
|
||
instead of having it always disabled in the UI, you should remove it.
jglick, do you agree?
Assignee | ||
Comment 7•24 years ago
|
||
I wanted to keep the UI, because if it is trivial to fix the actual problem then
we will just have to enable the UI. I will not be able to add any UI past
localization freeze, I believe it is in about 10 days.
btw, the actual problem is the pref "Use the address and do not search in the
directory" doesnot work.
That is what we have beening doing in the rest of the UI, yes. If it doesn't
currently work, remove it for now.
Comment 9•24 years ago
|
||
since this doesn't work, you should not show it in the UI.
but you can (and you did) keep the strings entities around. the L18n freeze is
all about adding new strings after localization has started.
you can still remove exising UI. You should comment out this UI (to remove it),
instead of disabling it.
then you'll be able to easily uncomment the UI to add it back once the feature
works.
the summary should be changed from "disable" to "remove"
Assignee | ||
Comment 10•24 years ago
|
||
o.k, will comment out the code to remove it. Will attach a new patch.
Updating summary to reflect that
Status: NEW → ASSIGNED
Summary: disable checkbox "Use the addressbook and do not search in the directory" → remove checkbox "Use the addressbook and do not search in the directory"
Assignee | ||
Comment 11•24 years ago
|
||
Comment 12•24 years ago
|
||
ok; r=mohanb;
Comment 13•24 years ago
|
||
sr=sspitzer
thanks for removing, instead of just disabling.
Comment 14•24 years ago
|
||
a= asa@mozilla.org for checkin to the trunk.
(on behalf of drivers)
Assignee | ||
Updated•23 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 15•23 years ago
|
||
Fix checked in on 6/8
Comment 16•23 years ago
|
||
reopening. The following error message is now appearing in the console after
going to the Addressing panel & then switching to another panel.
*** FIX ME: '_elementIDs' in 'pref-addressing.xul' contains a reference to a non
-existent element ID 'autocompleteSkipDirectory'.
autocompleteSkipDirectory needs to be removed from _elementIDs, since the code
that uses that id is commented out, to fix the error message stated above.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 17•23 years ago
|
||
Comment 18•23 years ago
|
||
sr=sspitzer
Comment 19•23 years ago
|
||
a=blizzard on behalf of drivers for the trunk
Assignee | ||
Comment 20•23 years ago
|
||
Fix checked in
Status: REOPENED → RESOLVED
Closed: 23 years ago → 23 years ago
Resolution: --- → FIXED
Updated•20 years ago
|
Product: MailNews → Core
Updated•16 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•