Closed
Bug 799834
Opened 12 years ago
Closed 12 years ago
Connect Android campaign product announcements preference to background service
Categories
(Firefox for Android Graveyard :: General, defect, P1)
Tracking
(firefox18 fixed)
RESOLVED
FIXED
Firefox 19
Tracking | Status | |
---|---|---|
firefox18 | --- | fixed |
People
(Reporter: rnewman, Assigned: rnewman)
References
Details
(Whiteboard: [snippets])
Attachments
(1 file)
(deleted),
patch
|
snorp
:
review+
bajaj
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Splitting this out to avoid bug confusion.
Assignee | ||
Comment 1•12 years ago
|
||
It turns out that preferences.xml stores its stuff somewhere other than GeckoApp's SharedPreferences file. This version is much simpler, because we just grab the value and send it out, rather than doing a dance with the receiver.
Attachment #670243 -
Flags: review?(snorp)
Updated•12 years ago
|
Attachment #670243 -
Flags: review?(snorp) → review+
Assignee | ||
Comment 2•12 years ago
|
||
Status: NEW → ASSIGNED
Target Milestone: --- → Firefox 19
Comment 3•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 4•12 years ago
|
||
Comment on attachment 670243 [details] [diff] [review]
Proposed patch. v1
Requesting Aurora approval to get product announcements (Bug 774497) into Firefox 18.
Impact: essentially zero. This just makes some log noise when you check and uncheck the "Show product announcements" checkbox in Fennec's settings screen.
No strings.
Attachment #670243 -
Flags: approval-mozilla-aurora?
Updated•12 years ago
|
Attachment #670243 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•12 years ago
|
Attachment #670243 -
Flags: approval-mozilla-aurora+ → approval-mozilla-aurora?
Comment 5•12 years ago
|
||
(before approving this and all other product announcement bugs, need to talk to the product team to verify they've discussed with the l10n community, if there is l10n impact)
Assignee | ||
Comment 6•12 years ago
|
||
(In reply to Alex Keybl [:akeybl] from comment #5)
> (before approving this and all other product announcement bugs, need to talk
> to the product team to verify they've discussed with the l10n community, if
> there is l10n impact)
If you mean for the Fennec side, the only string already landed in 18.
The server side is unrelated. Presumably product marketing and Services engineering are formulating a plan for how to generate the family of localized content that should be available to targeted locales, but the client doesn't care.
Comment 7•12 years ago
|
||
Comment on attachment 670243 [details] [diff] [review]
Proposed patch. v1
Approving as this patch does not have an l10n impact as the string changes are server side.
Attachment #670243 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Comment 8•12 years ago
|
||
status-firefox18:
--- → fixed
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•