Closed Bug 804441 Opened 12 years ago Closed 12 years ago

Put our NSPR and NSS header wrappers before OS_INCLUDES to allow inline functions in headers to call NSPR/NSS functions

Categories

(Firefox Build System :: General, defect, P1)

defect

Tracking

(blocking-basecamp:+, firefox18 fixed, firefox19 fixed)

RESOLVED FIXED
mozilla19
blocking-basecamp +
Tracking Status
firefox18 --- fixed
firefox19 --- fixed

People

(Reporter: briansmith, Assigned: briansmith)

References

Details

Attachments

(1 file, 1 obsolete file)

On Linux, without this patch, linking will fail when an inline function in a Mozilla header file (e.g. security/manager/ssl/src/ScopedNSSTypes.h) tries to call a function declared in a NSS header file, because the #includes within the Mozilla header file end up inheriting our default visibility: hidden. ssltunnel's and PSM's Makefiles work around this by putting $(NSPR_CFLAGS) $(NSS_CFLAGS) in LOCAL_INCLUDES. However, this workaround doesn't really scale for things like ScopedNSSTypes.h, especially when another Mozilla header from another module includes ScopedNSSTypes.h.
Updated patch to remove the media/mtransport changes. The media/mtransport stuff needs a different change that I'm not too sure about, because it doesn't use INCLUDES like the rest of the build system does. Regardless, fixing everything except webrtc is good enough for the immediate need.
Attachment #674086 - Attachment is obsolete: true
Attachment #674086 - Flags: review?(ted)
Attachment #674409 - Flags: review?(ted)
Setting the priority fields to make it clear that at least one basecamp blocker depends on this.
blocking-basecamp: --- → ?
Priority: -- → P1
Target Milestone: --- → mozilla19
Attachment #674409 - Flags: review?(ted) → review+
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: