Closed
Bug 806927
Opened 12 years ago
Closed 12 years ago
PBM - Add menu controls
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox20 verified)
VERIFIED
FIXED
Firefox 20
| Tracking | Status | |
|---|---|---|
| firefox20 | --- | verified |
People
(Reporter: ibarlow, Assigned: sriram)
References
Details
Attachments
(2 files)
|
(deleted),
image/png
|
Details | |
|
(deleted),
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
Menu mockup
Allow users to create new tabs and private tabs from the Android Menu. A mockup is attached.
Strings:
"New tab"
"New private tab"
Icon assets will be posted here shortly.
|
Assignee | |
Comment 1•12 years ago
|
||
This patch the two new menu items to the main menu.
I have added the images for "Synced tabs" and "close all tabs", along with the strings in this patch itself. (I couldn't go back and remove it and it got a bit tedious). This will be used in the tabs-menu (Bug 806933).
This patch has GB specific icons for those phones.
Attachment #682323 -
Flags: review?(mark.finkle)
|
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → sriram
|
||
Updated•12 years ago
|
Attachment #682323 -
Flags: review?(mark.finkle) → review+
|
|
Assignee | |
Comment 2•12 years ago
|
||
|
|
||
Comment 3•12 years ago
|
||
Backed out for failures
https://hg.mozilla.org/integration/mozilla-inbound/rev/a58070f72659
|
|
Assignee | |
Comment 4•12 years ago
|
||
Pushed again: https://hg.mozilla.org/integration/mozilla-inbound/rev/341dfa820cd5
(This has the new images included)
|
||
Comment 5•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
|
||
Comment 6•12 years ago
|
||
New private tab and New tab entries were added in Firefox Menu. Closing bug as verified fixed on:
Firefox 20.0a1 (2012-12-03)
Device: Galaxy S2
OS: Android 4.0.3
Status: RESOLVED → VERIFIED
status-firefox20:
--- → verified
|
||
Comment 7•12 years ago
|
||
Confused by the summary of this bug; looks like 'Close All Tabs' has been added regardless of any dependencies on PBM.
|
||
Updated•12 years ago
|
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•