Closed
Bug 808611
Opened 12 years ago
Closed 12 years ago
Reimplement valueOf shadowing protection using IDL
Categories
(Core :: XPConnect, defect)
Core
XPConnect
Tracking
()
RESOLVED
FIXED
mozilla19
People
(Reporter: bholley, Assigned: bholley)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
This is a less-brittle fix to bug 793969.
|
Assignee | |
Comment 1•12 years ago
|
||
This doesn't actually depend on the wrapper caching. Not sure what I was thinking.
No longer depends on: 808612
|
|
Assignee | |
Comment 2•12 years ago
|
||
Attachment #678381 -
Flags: review?(mrbkap)
|
||
Comment 3•12 years ago
|
||
Comment on attachment 678381 [details] [diff] [review]
Move valueOf to nsIDOMLocation. v1
Review of attachment 678381 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/base/nsLocation.cpp
@@ +915,5 @@
>
> +NS_IMETHODIMP
> +nsLocation::ValueOf(nsIDOMLocation** aReturn)
> +{
> + nsCOMPtr<nsIDOMLocation> loc(this);
loc = this
|
||
Comment 4•12 years ago
|
||
Comment on attachment 678381 [details] [diff] [review]
Move valueOf to nsIDOMLocation. v1
>- "valueOf", // IDX_VALUE_OF
>- IDX_VALUE_OF ,
Isn't it required to create an interned string early?
For example, IDX_OBJECT is not used at all other than creating an interned string.
https://mxr.mozilla.org/mozilla-central/search?string=IDX_OBJECT
|
|
Assignee | |
Comment 5•12 years ago
|
||
(In reply to Masatoshi Kimura [:emk] from comment #4)
> Comment on attachment 678381 [details] [diff] [review]
> Move valueOf to nsIDOMLocation. v1
>
> >- "valueOf", // IDX_VALUE_OF
> >- IDX_VALUE_OF ,
> Isn't it required to create an interned string early?
> For example, IDX_OBJECT is not used at all other than creating an interned
> string.
> https://mxr.mozilla.org/mozilla-central/search?string=IDX_OBJECT
I added those strings a few weeks ago in bug 793969, so my guess is that they're not critical.
|
||
Comment 6•12 years ago
|
||
Comment on attachment 678381 [details] [diff] [review]
Move valueOf to nsIDOMLocation. v1
Slick.
Attachment #678381 -
Flags: review?(mrbkap) → review+
|
|
Assignee | |
Comment 7•12 years ago
|
||
|
||
Comment 8•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/292958cd0d42
Should this have a test?
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
|
|
Assignee | |
Comment 9•12 years ago
|
||
(In reply to Ryan VanderMeulen from comment #8)
> https://hg.mozilla.org/mozilla-central/rev/292958cd0d42
>
> Should this have a test?
The relevant test here was checked in in bug 793969.
Flags: in-testsuite? → in-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•