Closed Bug 811406 Opened 12 years ago Closed 11 years ago

Work - Trim http:// and single trailing slash from location text in the Firefox app bar

Categories

(Firefox for Metro Graveyard :: Browser, defect, P3)

Product:
Firefox for Metro Graveyard
Component:
Browser
Platform:
All
Windows 8.1
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 24

People

(Reporter: mbrubeck, Assigned: jwilde)

References

Details

(Keywords: platform-parity, polish, ux-minimalism, Whiteboard: [shovel-ready] feature=work)

Attachments

(1 file, 1 obsolete file)

patch v1.1
(deleted), patch
fryn
: review+
Details | Diff | Splinter Review
We should hide "http://" at the start of the URL, and "/" at the end of the URL (if it is the only "/" in the URL). This should match the default behavior of desktop Firefox (bug 665580). We should also respect the browser.urlbar.trimURLs pref for users who want to disable this behavior.
Whiteboard: [metro-mvp?][LOE:1] → [metro-mvp][LOE:1]
Blocks: 831899
Whiteboard: [metro-mvp][LOE:1] → [metro-mvp][LOE:1] feature=work
Summary: Trim http:// and single trailing slash in the Metro URL bar → Work - Trim http:// and single trailing slash in the Metro URL bar
Whiteboard: [metro-mvp][LOE:1] feature=work → feature=work
Summary: Work - Trim http:// and single trailing slash in the Metro URL bar → Work - Trim http:// and single trailing slash in the location field of the Firefox app bar
Summary: Work - Trim http:// and single trailing slash in the location field of the Firefox app bar → Work - Trim http:// and single trailing slash from location text in the Firefox app bar
Blocks: 845152
No longer blocks: 831899
Priority: -- → P3
Whiteboard: feature=work → [shovel-ready] feature=work
Assignee: nobody → hello
Blocks: metrov1it9
No longer blocks: metrov1it9
Status: NEW → ASSIGNED
p=2, because there's some delicate interactions with the autocomplete XBL for this
Attached patch patch v1 (obsolete) (deleted) — — Splinter Review
Mostly just a straight copy of what desktop FF does, plus some tweaks to make things fit better into browser UI.
Attached patch patch v1.1 (deleted) — — Splinter Review
Whoops, committing blank lines again.
Attachment #762222 - Attachment is obsolete: true
Attachment #762238 - Flags: review?(fyan)
Comment on attachment 762238 [details] [diff] [review] patch v1.1 Review of attachment 762238 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/metro/theme/browser.css @@ +308,5 @@ > padding: 0 !important; > } > > +#urlbar-edit :invalid { > + box-shadow: none !important; Interesting. Comment this plz.
Attachment #762238 - Flags: review?(fyan) → review+
Comment on attachment 762238 [details] [diff] [review] patch v1.1 Review of attachment 762238 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/metro/base/content/browser-ui.js @@ +721,5 @@ > + let spec = uri.spec; > + let trimmedSpec = this.trimURL(spec); > + if (spec != trimmedSpec) { > + // Prepend the portion that trimValue removed from the beginning. > + // This assumes trimValue will only truncate the URL at These comments should be updated to say trimURL instead of trimValue. Will update before landing on inbound.
Blocks: 877666
https://hg.mozilla.org/mozilla-central/rev/459cc5f50007
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 24
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: