Observed when verifying the fix for bug 63225: Build ID: Windows 2000 build 2001-05-16-08 RedHat 7.0 build 2001-05-16-06 Mac OS 9.1 build 2001-05-16-08 1. Context click on an image in the message pane. 2. Look at the string after "Save Image" that appears on the context menu. Expected Results: Save Image (MVC-178f.jpg) Actual Results: Save Image (jpeg&filename=MVC-178f.jpg) Caving did the fix for bug 63225, so I'm hoping he won't mind taking a look at this.

thanks for logging this. cavin and I saw this when testing. see extractFileNameFromUrl(). that just gets the name by using the last "/". works fine for "http://foo/bar/cheese.jpg", but not for our mailnews urls.

Like Seth said, the display name is toally up to extractFileNameFromUrl(). The url of the image is something like (line is too long so make it into two): imap://user@host.com:143/fetch>UID>/INBOX>951 ?part=1.2&type=image/gif&filename=foo.jpeg That's why 'jpeg&filename=foo.fig' is displayed.

Nominating for nsbeta1, since this is just kinda goofy. We should fix extractFileNameFromUrl()

Added code to extract file name after string "filename=", if present.

Navin and Seth, can you review the patch? Thanks.

Comment on attachment 62153 [details] [diff] [review] Patch file. r=naving, looks like your fix will work with news and local also.

Adding dependency on bug 73946 since without it we really can't save the images.

that seems fine, since we that's how generate images urls in mimeiimg.cpp, MimeInlineImage_parse_begin() you might want to add that information in the comment. Does it work properly if the image name is "filename=x.gif", does that get escaped so that the url is imap://user@host.com:143/fetch>UID>/INBOX>951 ?part=1.2&type=image/gif&filename=filename%3Dx.gif" sr=sspitzer

Ccing ben@netscape.com for review since we don't own file xpfe/communicator/resources/content/utilityOverlay.js.

Ben, can you review the patch before I check it in?

Comment on attachment 62153 [details] [diff] [review] Patch file. r=ben@netscape.com

Fix checked in.

Verified FIXED with: RedHat 7.2 - 2002-02-13-08 Windows 2K - 2002-02-13-03 Mac OS X - 2002-02-12-03 File types: JPEG, BMP, GIF, PNG. Used both the attachment tree and the context menu items.