I finally fixed the problem that was causing the crazy linking problems, thanks to glandium. See bug 813241 and see try run: https://tbpl.mozilla.org/?tree=Try&rev=769af0c72021

not blocking, p3, but it will get landed RSN I'm sure.

Comment on attachment 683898 [details] [diff] [review] Replace manual resource management with usage of ScopedNSSTypes types Review of attachment 683898 [details] [diff] [review]: ----------------------------------------------------------------- These look fine. Have they been tested?

(In reply to Eric Rescorla from comment #2) > These look fine. Have they been tested? I have used the Scoped* templates in other patches that have been tested. And, also I ran this through try to make sure it would build and all of the tests that run on try passed.

OK, we don't yet have automated testing for this code. I will test it and get back to you.

Comment on attachment 683898 [details] [diff] [review] Replace manual resource management with usage of ScopedNSSTypes types It looks like this patch is still relevant, but it's outdated. Stuff like ScopedPK11SlotInfo based on the deprecated Scoped.h should not be used anymore. The UniquePtr equivalents like UniquePK11SlotInfo should be used instead.

Mass change P3->P4 to align with new Mozilla triage process.