Closed
Bug 814509
Opened 12 years ago
Closed 12 years ago
Downloads summary background is different from "Show all downloads" button background
Categories
(Firefox :: Downloads Panel, defect)
Tracking
()
VERIFIED
FIXED
Firefox 20
People
(Reporter: mconley, Assigned: mconley)
References
Details
(Keywords: polish)
Attachments
(4 files)
A little detail slipped by - the "Show all downloads" button background is different between the Aero and non-Aero winstripe themes.
The summary background is using the non-Aero background color in either the Aero or non-Aero case.
See screenshot.
Assignee | ||
Comment 1•12 years ago
|
||
Assignee | ||
Comment 2•12 years ago
|
||
Here's what we look like on winstripe aero now.
Assignee | ||
Updated•12 years ago
|
Attachment #684755 -
Flags: review?(mak77)
Comment 3•12 years ago
|
||
I would have preferred the other way round, darker color in both states. (Just my personal opinion, laying it down so that it might get consideration)
Comment 4•12 years ago
|
||
Comment on attachment 684755 [details] [diff] [review]
Patch v1
Review of attachment 684755 [details] [diff] [review]:
-----------------------------------------------------------------
::: browser/themes/winstripe/downloads/downloads-aero.css
@@ +7,5 @@
> %undef WINSTRIPE_AERO
>
> @media (-moz-windows-default-theme) {
> + #downloadsPanel[hasdownloads] > #downloadsHistory,
> + #downloadsSummary {
as a cleanup, in future we may evaluate to move all the styling to the footer vbox. Btw, fine for now.
Attachment #684755 -
Flags: review?(mak77) → review+
Assignee | ||
Comment 5•12 years ago
|
||
Thanks! Landed on inbound as https://hg.mozilla.org/integration/mozilla-inbound/rev/47465b730696
Filed a follow-up bug to generalize those CSS rules at bug 815131.
Comment 6•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
This bug is still present when we have less than 4 elements on list (so there is "Show all Downloads" button instead of "+X more Downloads").
Assignee | ||
Comment 8•12 years ago
|
||
(In reply to Michał from comment #7)
> This bug is still present when we have less than 4 elements on list (so
> there is "Show all Downloads" button instead of "+X more Downloads").
Are you sure? Here's what I'm seeing on Windows 7.
http://i.imgur.com/jhRhD.png
This is what I see on Win7, Nightly build 2012-11-29.
Assignee | ||
Comment 10•12 years ago
|
||
(In reply to Michał from comment #9)
> http://i.imgur.com/jhRhD.png
>
> This is what I see on Win7, Nightly build 2012-11-29.
Argh, yes, I see it too now. The addition of the footer node busted that rule. The review and screenshot for this must have been uploaded when the footer node hadn't been added yet.
Thankfully, I believe this is being taken care of by bug 815131 (this bug consolidated some CSS rules), which just landed, so I think we're OK.
Comment 11•12 years ago
|
||
Mozilla/5.0 (Windows NT 6.1; rv:20.0) Gecko/20121204 Firefox/20.0
Build ID: 20121204030754
Verified as fixed on Windows 7 using the latest Nightly - the summary background the same in either the Aero or non-Aero case, regardless of the number of downloads (more or less than 4).
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•