Closed
Bug 819172
Opened 12 years ago
Closed 12 years ago
js standalone builds are broken
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Benjamin, Unassigned)
References
Details
(Keywords: regression)
$ cd _DBG.OBJ
$ ../configure --enable-debug
$ make -sj9
make: `symverscript' is up to date.
The last step doesn't build the JS engine.
This patch "fixes" it:
diff -r dee7d08baf04 js/src/Makefile.in
--- a/js/src/Makefile.in Thu Dec 06 22:41:37 2012 +0000
+++ b/js/src/Makefile.in Thu Dec 06 19:46:09 2012 -0500
@@ -538,20 +538,16 @@ ifeq (,$(MOZ_GLUE_PROGRAM_LDFLAGS))
include $(MFBT_ROOT)/sources.mk
DEFINES += -DIMPL_MFBT
endif
# ensure symbol versions of shared library on linux do not conflict with those in libxul
ifeq (Linux,$(OS_TARGET))
EXTRA_DSO_LDOPTS += -Wl,-version-script,symverscript
-symverscript: symverscript.in
- $(PYTHON) $(topsrcdir)/config/Preprocessor.py \
- -DVERSION="$(subst -,_,$(LIBRARY_NAME))" $< > $@
-
EXTRA_DEPS += symverscript
endif
EXTRA_DSO_LDOPTS += $(NSPR_LIBS)
ifndef BUILD_OPT
MOCHAFILE = 1
Comment 1•12 years ago
|
||
Where did you get this source from, I don't see "symverscript" in any of our current code release trains.
Also I suspect your patch is wrong anyway, it looks merely like a default make target mistake (by being the first target parsed) and not something you'd want to remove the target for.
Reporter | ||
Comment 2•12 years ago
|
||
Look at m-i. I'm not saying the patch is good, just that it fixes the build. :)
Comment 3•12 years ago
|
||
Ahh I'm not used to people reporting bugs against inbound in non-default (in mozilla-continuous integration) configurations, so didn't catch this.
This is a regression/problem in http://hg.mozilla.org/integration/mozilla-inbound/rev/75e0d521bc2b - Bug 809430 - Add symbol-versions to libxul and libmozjs for linux. r=glandium
For a surprise to me this bustage was even with a build-system peer reviewing ;-) so I'll hand over to the gentoo guy and glandium to fix.
Comment 4•12 years ago
|
||
I backed out https://hg.mozilla.org/integration/mozilla-inbound/rev/75e0d521bc2b to fix this. Clearly none of us have any idea what the right fix is, best to punt back to the original author. :-)
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment 5•12 years ago
|
||
Ah, the rule is too high in the file and is picked as default.
Comment 6•12 years ago
|
||
I thought bug 777379 should have prevented this sort of bustage?
Comment 7•12 years ago
|
||
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #6)
> I thought bug 777379 should have prevented this sort of bustage?
.DEFAULT_GOAL is unfortunately a GNU make 3.81 feature.
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•