Closed Bug 819974 Opened 12 years ago Closed 12 years ago

[Apps] Allow to cancel hosted app download

Categories

(Core Graveyard :: DOM: Apps, defect, P1)

Product:
Core Graveyard
Component:
DOM: Apps
Type:
defect

Tracking

(blocking-basecamp:+, firefox19 fixed, firefox20 fixed, b2g18 fixed)

Status:
VERIFIED FIXED
Milestone:
B2G C3 (12dec-1jan)
Project Flags:
blocking-basecamp +
Tracking Flags:
Tracking Status
firefox19 --- fixed
firefox20 --- fixed
b2g18 --- fixed

People

(Reporter: ferjm, Assigned: ferjm)

References

Details

(Keywords: feature)

Attachments

(1 file, 2 obsolete files)

v2
(deleted), patch
fabrice
: review+
Details | Diff | Splinter Review
We need the ability to cancel hosted app installations in order to fully implement the Gaia app install specs. More info in Bug 816128.
Blocker of a blocker, so I guess this one should be bb+ too.
Assignee: nobody → ferjmoreno
Blocks: 816128
blocking-basecamp: --- → ?
Depends on: 819971
Blocks: 818848
Summary: [Apps] Allow to cancel hosted app installations → [Apps] Allow to cancel hosted app download
Attached patch v1 (obsolete) (deleted) — — Splinter Review
I'd like to do more tests before asking for r?
Attached patch v1 (obsolete) (deleted) — — Splinter Review
It seems to be working properly. I'm just updating the patch to remove some trailing white spaces. This patch won't land until Bug 819971 does.
Attachment #691327 - Attachment is obsolete: true
Attachment #691389 - Flags: review?(fabrice)
Comment on attachment 691389 [details] [diff] [review] v1 Review of attachment 691389 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/apps/src/Webapps.jsm @@ +866,5 @@ > return; > } > + > + if (download.cacheUpdate) { > + // Cancell hosted app download. Nit: Cancel @@ +869,5 @@ > + if (download.cacheUpdate) { > + // Cancell hosted app download. > + download.cacheUpdate.cancel(); > + } else if (download.channel) { > + // Cancell packaged app download. ditto
Attachment #691389 - Flags: review?(fabrice) → review+
Attached patch v2 (deleted) — — Splinter Review
I had to modify the patch because of the changes that I've made for Bug 819971. Now we don't use the nsIOfflineCacheUpdateObserver::STATE_CANCELLED state, but we reuse the STATE_ERROR one. Fabrice, I won't ask you for r? again to not spam your request queue, but feel free to take a look at the patch again :).
Attachment #691389 - Attachment is obsolete: true
Attachment #692279 - Flags: review?(fabrice)
Attachment #692279 - Flags: review?(fabrice) → review+
Driver retriage: QA, please ensure scenario in bug 816128 is covered. They are 100% identical, but want to ensure we're not missing anything. Also, can this land now?
Keywords: feature
Priority: -- → P1
Target Milestone: --- → B2G C3 (12dec-1jan)
We have to wait for Bug 819971 to land. Hopefully that will happen today.
https://hg.mozilla.org/mozilla-central/rev/ba2f2f5fb6b2
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Keywords: verifyme
QA Contact: jsmith
Verified - I've confirmed I cancel a hosted app download preloading appcache.
Status: RESOLVED → VERIFIED
Keywords: verifyme
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: