See http://hg.mozilla.org/mozilla-central/annotate/c574f7f68309/browser/base/content/browser-plugins.js#l283. Underscored methods are considered private and are not expected to be called outside of their module. This line of code will need to be changed to not depend on this private method. I haven't tested it yet, but I think a call to PopupNotifications.show() can be used here instead of the update.

(In reply to Jared Wein [:jaws] from comment #0) > This line of code will need to be changed to not depend on this private > method. I haven't tested it yet, but I think a call to > PopupNotifications.show() can be used here instead of the update. Another option is to expose a public "update()" method on PopupNotifications (which may just call _update(), but at least then the expectations are clear that it's a publicly exposed method and meant to be "supported" for that use).

Something like this?

Comment on attachment 698954 [details] [diff] [review] patch Review of attachment 698954 [details] [diff] [review]: ----------------------------------------------------------------- Yeah, that looks good to me.

Try run: https://tbpl.mozilla.org/?tree=Try&rev=4d0a4b7d0697 Looks good, so: https://hg.mozilla.org/integration/mozilla-inbound/rev/ffc6d0bf70fe

I guess it's debatable whether this should get super-review, but it surely needs review from a toolkit peer...

Comment on attachment 698954 [details] [diff] [review] patch "reshow" is an odd external API - it's a bit confusing what it would do, and why it takes an anchor. On the other hand, notification.reshow() is pretty straightforward. So we can probably just have the Notification method call the internal PopupNotifications method, and not expose anything "public" on PopupNotifications.

We should also update https://developer.mozilla.org/en-US/docs/Mozilla/JavaScript_code_modules/PopupNotifications.jsm#The_Notification_object . David, could you land this if you have no objections?

Comment on attachment 699536 [details] [diff] [review] like this Thanks, Gavin!