Closed
Bug 821687
Opened 12 years ago
Closed 11 years ago
Status panel should be attached to the content area without overlapping surrounding chrome
Categories
(Firefox :: General, defect)
Tracking
()
VERIFIED
FIXED
Firefox 26
People
(Reporter: paul, Assigned: dao)
References
(Regression)
Details
(Keywords: addon-compat, regression)
Attachments
(2 files, 2 obsolete files)
(deleted),
patch
|
mikedeboer
:
review+
akeybl
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
(deleted),
image/png
|
Details |
We want the statusbar to be above the devtools box. That means moving the statusbar inside the tab. That would imply building one statusbar per tab.
Reporter | ||
Comment 1•12 years ago
|
||
Dao, do you think it's something feasible?
Assignee | ||
Comment 2•12 years ago
|
||
I don't think one status panel per tab this is very reasonable, given the global nature of the XULBrowserWindow infrastructure.
Reporter | ||
Comment 3•12 years ago
|
||
Possible workaround: when the toolbox is present in the current tab, we translate (as is transform:translateY()) the statusbar.
Comment 4•11 years ago
|
||
Translating the statusbar. This is not the final version and a lot of cases are missed out. But asking for feedback to see if this approach is acceptable.
Assignee | ||
Comment 5•11 years ago
|
||
Comment on attachment 754223 [details] [diff] [review]
patch v0.1
I'd rather not have external code mess with the status panel's position. If multiple actors did that, things would quickly get messy, as you assume you're the only one setting a CSS transform on the status panel.
Attachment #754223 -
Flags: feedback?(dao) → feedback-
Comment 6•11 years ago
|
||
So any suggestions here , anyone ?
Updated•11 years ago
|
Updated•11 years ago
|
Comment 7•11 years ago
|
||
[this is out of my scope now :) ]
Assignee: scrapmachines → nobody
Status: ASSIGNED → NEW
Updated•11 years ago
|
Attachment #754223 -
Attachment is obsolete: true
Reporter | ||
Comment 8•11 years ago
|
||
(In reply to Dão Gottwald [:dao] from comment #5)
> Comment on attachment 754223 [details] [diff] [review]
> patch v0.1
>
> I'd rather not have external code mess with the status panel's position. If
> multiple actors did that, things would quickly get messy, as you assume
> you're the only one setting a CSS transform on the status panel.
So any idea of what we can do to fix this issue?
Assignee | ||
Updated•11 years ago
|
Assignee | ||
Comment 9•11 years ago
|
||
Assignee | ||
Updated•11 years ago
|
Summary: Status panel should be attached to the content area without overlapping chrome elements → Status panel should be attached to the content area without overlapping surrounding chrome
Assignee | ||
Comment 10•11 years ago
|
||
fixed a nit
Attachment #803704 -
Attachment is obsolete: true
Attachment #803704 -
Flags: review?(mdeboer)
Attachment #803707 -
Flags: review?(mdeboer)
Comment 11•11 years ago
|
||
lgtm, I triggered a try build to see if this breaks any tests:
https://tbpl.mozilla.org/?tree=Try&rev=5acd3a1dbb8d
...which includes the backout patches from bug 914180.
Updated•11 years ago
|
Attachment #803707 -
Flags: review?(mdeboer) → review+
Comment 12•11 years ago
|
||
Would it be a good idea to add a (regression) unit test for this?
Assignee | ||
Comment 13•11 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/b47e5a0b7704
I have no idea how a useful test for this might look like...
Comment 14•11 years ago
|
||
(In reply to Dão Gottwald [:dao] from comment #13)
> I have no idea how a useful test for this might look like...
No idea either. I guess I just wanted to have it mentioned. ;)
Comment 15•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
Comment 17•11 years ago
|
||
Comment on attachment 803707 [details] [diff] [review]
patch
[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 914180
User impact if declined: When the patch in bug 914180 lands on Aurora, the status panel will cover the findbar when it's open. This patch fixes that.
Testing completed (on m-c, etc.): one day on m-c, required for backout.
Risk to taking this patch (and alternatives if risky): low
String or IDL/UUID changes made by this patch: none
Attachment #803707 -
Flags: approval-mozilla-aurora?
Updated•11 years ago
|
Attachment #803707 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•11 years ago
|
Keywords: checkin-needed
Comment 18•11 years ago
|
||
status-firefox25:
--- → fixed
status-firefox26:
--- → fixed
Flags: in-testsuite-
Keywords: checkin-needed
Comment 19•11 years ago
|
||
On: XP 32-bit, Ubuntu 12.10 32-bit and Mac OS X 10.7.5 in 32-bit mode, with latest Aurora (build ID: 20130926004003) and 25 beta 2 (build ID: 20130923194050) I can see the status bar above the developer toolbox, in both scenarios:
1) when reloading a page
2) when hovering an URL from the page
Please see the attached screenshot for details. I'm assuming this is the discussed issue here, right?
Flags: needinfo?(paul)
Reporter | ||
Comment 20•11 years ago
|
||
(In reply to Manuela Muntean [:Manuela] [QA] from comment #19)
> Created attachment 810538 [details]
> Screenshot.png
>
> On: XP 32-bit, Ubuntu 12.10 32-bit and Mac OS X 10.7.5 in 32-bit mode, with
> latest Aurora (build ID: 20130926004003) and 25 beta 2 (build ID:
> 20130923194050) I can see the status bar above the developer toolbox, in
> both scenarios:
>
> 1) when reloading a page
> 2) when hovering an URL from the page
>
> Please see the attached screenshot for details. I'm assuming this is the
> discussed issue here, right?
Indeed. You see the valid behavior (status bar not hovering the tools).
Flags: needinfo?(paul)
Comment 21•11 years ago
|
||
Marking this verified, based on comment 19 and comment 20. Thanks Paul!
Updated•11 years ago
|
Keywords: addon-compat
Assignee | ||
Updated•4 years ago
|
Updated•4 years ago
|
Keywords: regression
Updated•3 years ago
|
Has Regression Range: --- → yes
You need to log in
before you can comment on or make changes to this bug.
Description
•