Closed
Bug 823021
Opened 12 years ago
Closed 12 years ago
Remove hard coded windows dll paths from WMFUtils.cpp
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
DUPLICATE
of bug 823924
People
(Reporter: jimm, Unassigned)
Details
http://mxr.mozilla.org/mozilla-central/source/content/media/wmf/WMFUtils.cpp#213
Presumably what ehsan meant in bug 799315 was to dynamically get the location of these dlls.
Not sure if we even need to do that since I think the system dll loader protects most system dlls (like user32, etc..) from getting hijacked. I'd guess these wmf dlls get the same treatment.
Either way the hard coded paths to "c:\windows" have got to go.
Comment 1•12 years ago
|
||
WinXP systems woldn't know about mf DLLs.
That said, I also think we don't need the full path here because all supported systems have SetDllDirectory now.
Reporter | ||
Comment 2•12 years ago
|
||
(In reply to Masatoshi Kimura [:emk] from comment #1)
> WinXP systems woldn't know about mf DLLs.
> That said, I also think we don't need the full path here because all
> supported systems have SetDllDirectory now.
So if this wmf code won't work on xp due to missing dlls, we should be doing a simple os version check. I hope we're not relying on a failed dll load to detect support if we already know support isn't there.
Comment 3•12 years ago
|
||
(In reply to Jim Mathies [:jimm] from comment #2)
> So if this wmf code won't work on xp due to missing dlls, we should be doing
> a simple os version check.
The version check is already present.
https://hg.mozilla.org/mozilla-central/rev/a75e9af08e9c#l17.94
> I hope we're not relying on a failed dll load to
> detect support if we already know support isn't there.
We removed such a reliance as a part of preventing DLL hijacking attack.
Comment 4•12 years ago
|
||
Yeah, what emk said.
I'm going on holiday for three weeks, so I'll deal with this when I get back, unless some enthusiastic person wants it handled before that.
Comment 5•12 years ago
|
||
Duping against bug 823924, since it has the patch we are discussing here (i.e. removing the absolute path).
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•