Closed Bug 824153 Opened 12 years ago Closed 10 years ago

JS error when ordering from swisschalet.ca (buttonName is null)

Categories

(Web Compatibility :: Desktop, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: milan, Unassigned)

References

()

Details

(Keywords: regression, Whiteboard: [country-ca] [needaccount] [sitewait])

Attachments

(2 files)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_7_5) AppleWebKit/534.57.7 (KHTML, like Gecko) Version/5.1.7 Safari/534.57.7 Steps to reproduce: swisschalet.ca, login, grab an entree; it will ask for the sides, go through the workflow, then click finish. It appears that it's bad JS, but safari got through it. Actual results: The site tells you there was an error and to phone in instead. JS console has these two errors: Timestamp: 12-12-21 7:32:31 PM Error: TypeError: buttonName is null Source File: https://web.swisschaletordering.com/Exit41Online/customize-menu-item.htm Line: 159 Timestamp: 12-12-21 7:32:26 PM Error: TypeError: buttonName is null Source File: https://web.swisschaletordering.com/Exit41Online/customize-menu-item.htm?lastMoveWasForward=true&orderItemId=131572484&qtyValue=1&categoryId=favorites&updateFlag=true&itemId=3900&mode=edit&mealItemId=3690 Line: 567 Expected results: No error, and you get the food. Worked in safari.
Since you already have a login, mind attaching the HTML of the page in question so I can see what line 159 and 567 look like?
Flags: needinfo?(milan)
Attached file The page just before the error (deleted) —
Here is the page just before the error. Clicking on the "Finish" button causes the error (next attachment).
Flags: needinfo?(milan)
Attached file The error page itself (deleted) —
After clicking Finish button on the previous page, this is what we get.
Hmm. That page defines a buttonName and that part should work fine.... But it doesn't have anything resembling script on the line numbers in comment 0. I'm also not sure which of those two URIs this page is, if either one. A question. Does this work in older Firefox versions?
Flags: needinfo?(milan)
Yes, there is a regression: STR: 1) Open http://swisschalet.ca/online_ordering_province_select.php 2) Login with guest account: Email: paul@monemail.fr.nf Password: azerty123! 3) On tab "Pickup/delivery", select pickup (red square "Call ahead take-out") 4) On tab "Select restaurant", select city "Toronto" and province "ON-Ontario" then choose a random restaurant (e.g. "A") 5) On tab "Pickup time", select a random "Future date" 6) On tab "Order entry", select "Classic Quarter Chicken" in Favourites 7) Select a "Chicken choice" then click on "Select next side" 8) Select a "Side" and click on "Finish" Result: The website should display your order on the right: http://i.imgur.com/7bOWg.jpg When that fails, the website displays an error: http://i.imgur.com/J7CpH.jpg Regression range: m-c good=2012-06-05 bad=2012-06-06 http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=a7a905fd70d5&tochange=6338a8988917 Maybe an issue with Paris bindings.
Flags: needinfo?(milan)
Version: 17 Branch → 16 Branch
Regression window(m-i) Good: http://hg.mozilla.org/integration/mozilla-inbound/rev/eee5cd8316af Mozilla/5.0 (Windows NT 6.1; WOW64; rv:15.0) Gecko/15.0 Firefox/15.0a1 ID:20120604164643 Bad: http://hg.mozilla.org/integration/mozilla-inbound/rev/f0f924ac58d2 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:15.0) Gecko/15.0 Firefox/15.0a1 ID:20120604180843 Pushlog: http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=eee5cd8316af&tochange=f0f924ac58d2 Suspected : 28dd33748be5 David Zbarsky — Bug 591467 - Implement HTML5 Microdata API r=bz
They use |jQuery(this).attr('itemId')| in https://web.swisschaletordering.com/Exit41Online/split-customization.js ,menupage.js etc. I think it may conflict with Microdata API.
Blocks: 591467
Ah, yes, if they're using an old broken jQuery version. See https://twitter.com/bz_moz/status/270548730959245312 Note that WebKit doesn't implement the microdata API yet, which is why things work there. Milan, if you have an account with this site, would you mind dropping them a note about the problem?
Assignee: nobody → english-other
Component: DOM: Core & HTML → English Other
Product: Core → Tech Evangelism
Version: 16 Branch → unspecified
And Alice0775, thank you for hunting down what's going on yet again!
(In reply to Boris Zbarsky (:bz) from comment #8) > > Milan, if you have an account with this site, would you mind dropping them a > note about the problem? I'll do that.
https://order.swisschalet.com/order/ I went through the process and I had no issue. The site has changed designed since. And the orders are rightly incremented.
Assignee: english-other → nobody
Status: NEW → RESOLVED
Closed: 10 years ago
Component: English Other → Desktop
Resolution: --- → FIXED
Whiteboard: [country-ca] [needaccount] [sitewait]
Product: Tech Evangelism → Web Compatibility
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: