Closed
Bug 825892
Opened 12 years ago
Closed 12 years ago
rm JSOP_LOOKUPSWITCH
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla20
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(1 file)
(deleted),
patch
|
bhackett1024
:
review+
|
Details | Diff | Splinter Review |
Compiling LOOKUPSWITCH is complicated, and this op hurts JIT performance more than it helps:
* IonMonkey compiles LOOKUPSWITCH and CONDSWITCH to the same MIR. Handling these ops adds a lot of complexity to IonBuilder.
* JM(+TI) always stubs LOOKUPSWITCH and usually spends a lot of time in FindNativeCode. Without LOOKUPSWITCH we'd use CONDSWITCH/CASE/DEFAULT and in many cases these are faster because they can avoid stub calls.
* Efficiently compiling LOOKUPSWITCH in the new baseline compiler is also not trivial, especially compared to CONDSWITCH/CASE which can just use the existing equality IC.
Assignee | ||
Comment 1•12 years ago
|
||
18 files changed, 68 insertions(+), 722 deletions(-)
Attachment #697110 -
Flags: review?(bhackett1024)
Comment 2•12 years ago
|
||
Comment on attachment 697110 [details] [diff] [review]
Remove JSOP_LOOKUPSWITCH
Review of attachment 697110 [details] [diff] [review]:
-----------------------------------------------------------------
Nice!
Attachment #697110 -
Flags: review?(bhackett1024) → review+
Assignee | ||
Comment 3•12 years ago
|
||
Comment 4•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in
before you can comment on or make changes to this bug.
Description
•