Closed
Bug 825970
Opened 12 years ago
Closed 7 years ago
Changing the volume level of short sound is hard
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(blocking-basecamp:-, b2g18+, b2g-v2.0 affected, b2g-v2.1 affected)
RESOLVED
WONTFIX
blocking-basecamp | - |
People
(Reporter: vingtetun, Assigned: alive)
References
Details
(Whiteboard: permafail)
+++ This bug was initially created as a clone of Bug #825674 +++
## Environment :
Unagi phone, build 2012-12-31
## Repro :
1. install Solitaire from the Marketapp
2. turn the sound on in the option after launching the game (select menu -> option -> settings -> Package - Wood )
3. using the hardware control turn the sound all the way down
Gaia should offer a timeout to let the user change the volume of the sound that has been played in the last 2 seconds (this can be changed). I won't block on this though.
## Expected :
1. no sound occurs
## Actual :
1. you can still hear the sound and it's unaffected by the volume control.
## Note :
1. music app and video app work correctly.
2. from feedback
Reporter | ||
Updated•12 years ago
|
blocking-basecamp: ? → ---
Summary: Installed apps do not get affected by the hardware volume control → Changing the volume level of short sound is hard
Updated•12 years ago
|
Assignee: nobody → amarchesini
Assignee | ||
Updated•12 years ago
|
blocking-basecamp: --- → ?
Assignee | ||
Updated•12 years ago
|
Assignee: amarchesini → alive
Comment 1•12 years ago
|
||
What's the proposed fix here?
Assignee | ||
Comment 2•12 years ago
|
||
(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) from comment #1)
> What's the proposed fix here?
See https://bugzilla.mozilla.org/show_bug.cgi?id=825674#c30
Proposal:
Keep a 2 second buffer when the channel is changed from 'normal'/'content' to 'none'(default).
Clear the buffer when any new channel arrives.
Comment 3•12 years ago
|
||
(In reply to Alive Kuo [:alive] from comment #2)
> (In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) from comment #1)
> > What's the proposed fix here?
>
> See https://bugzilla.mozilla.org/show_bug.cgi?id=825674#c30
> Proposal:
> Keep a 2 second buffer when the channel is changed from 'normal'/'content'
> to 'none'(default).
> Clear the buffer when any new channel arrives.
Are we counting that in sound_manager.js in Gaia or nsIAudioChannelService? If latter we might be able to fix bug 825824 and bug 819852 altogether.
Assignee | ||
Comment 4•12 years ago
|
||
(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) from comment #3)
> (In reply to Alive Kuo [:alive] from comment #2)
> > (In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) from comment #1)
> > > What's the proposed fix here?
> >
> > See https://bugzilla.mozilla.org/show_bug.cgi?id=825674#c30
> > Proposal:
> > Keep a 2 second buffer when the channel is changed from 'normal'/'content'
> > to 'none'(default).
> > Clear the buffer when any new channel arrives.
>
> Are we counting that in sound_manager.js in Gaia or nsIAudioChannelService?
> If latter we might be able to fix bug 825824 and bug 819852 altogether.
Seems they are much similar in 'make a buffer' if bug 819852 and bug 825824 are going to be resolved in gecko.
I wonder the timing of firing audio-channel-changed event is binding to the solution of bug 819824 and bug 825824...
Personally doing this in system app is more feasible I think -- to modify the buffer length.
Comment 5•12 years ago
|
||
Triage: BB-, tracking-b2g18+
blocking-basecamp: ? → -
tracking-b2g18:
--- → +
Assignee | ||
Comment 6•12 years ago
|
||
Nominate again.
Bug 825674 is set to bb+ by the same bug description as this bug but the its title is changed and the solution to bug 825674 doesn't solve the original description. I don't know why this is not blocked.
blocking-basecamp: - → ?
Updated•12 years ago
|
blocking-basecamp: ? → -
Assignee | ||
Comment 7•12 years ago
|
||
Need info to Casey to get his attention on this bug.
Flags: needinfo?(kyee)
I don't think setting a timeout is the solution here. This only works for scenarios where you can hear the sound and adjust levels after the sound fires. In cases where user sets the audio level to 0 there is no way for the user to know that audio is being played and adjust accordingly. This solution is also difficult for the user to understand.
I think the better solution is to adjust the sound based on application context. If the application makes sounds (Solitaire for example) and is currently in focus, adjusting the volume up/down should adjust the application audio. If the application does not make sound (like gallery) then adjusting audio adjusts the ringer volume.
Flags: needinfo?(kyee)
Assignee | ||
Comment 9•12 years ago
|
||
I am afraid that we couldn't know which app is making sounds..
Assignee | ||
Comment 10•12 years ago
|
||
(In reply to Casey Yee [:cyee] from comment #8)
> I don't think setting a timeout is the solution here. This only works for scenarios where you can hear the sound and adjust levels after the sound fires. In cases where user sets the audio level to 0 there is no way for the user to know that audio is being played and adjust accordingly. This solution is also difficult for the user to understand.
I don't understand why if the user cannot hearing matters. They different things and the original design have the same 'problem'.
> I think the better solution is to adjust the sound based on application
> context. If the application makes sounds (Solitaire for example) and is
> currently in focus, adjusting the volume up/down should adjust the
> application audio. If the application does not make sound (like gallery)
> then adjusting audio adjusts the ringer volume.
This violates: "adjusting background music if it's playing background." because "only change the focused app" here.
I would give a patch using timer coz bug 784184 is going to be backed out.
Comment 11•12 years ago
|
||
I had a chat with Jonas and we agree that for the time being suggestion offered in comment 0 is a suitable stop-gap until we can come up with a better scheme:
(In reply to Vivien Nicolas (:vingtetun) (:21) from comment #0)
> Gaia should offer a timeout to let the user change the volume of the sound
> that has been played in the last 2 seconds (this can be changed).
This will only apply for scenarios where this is no continuous foreground or background audio playing (such as music and fm radio).
This is making audio for apps very confusing for users. Something we really should fix for leo.
blocking-b2g: --- → leo?
Comment 13•12 years ago
|
||
triage: tracking-b2g18+, would not block release with this but would take a patch and consider for uplift approval
blocking-b2g: leo? → ---
Updated•10 years ago
|
QA Whiteboard: [QAnalyst-Triage?]
status-b2g-v2.0:
--- → affected
Flags: needinfo?(ktucker)
Whiteboard: [feedback] → [feedback], [2.0-flame-test-run-3]
Updated•10 years ago
|
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
Updated•10 years ago
|
QA Whiteboard: [QAnalyst-Triage+] → [QAnalyst-Triage+][lead-review+]
Updated•10 years ago
|
QA Whiteboard: [QAnalyst-Triage+][lead-review+] → [QAnalyst-Triage?][lead-review+]
status-b2g-v2.1:
--- → affected
Flags: needinfo?(dharris)
Whiteboard: [feedback], [2.0-flame-test-run-3] → permafail
Updated•10 years ago
|
QA Whiteboard: [QAnalyst-Triage?][lead-review+] → [QAnalyst-Triage+][lead-review+]
Flags: needinfo?(dharris)
Comment 14•7 years ago
|
||
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•