Closed Bug 829579 Opened 12 years ago Closed 12 years ago

AllFramesIter should iterate Ion frames

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla21

People

(Reporter: jandem, Assigned: jandem)

References

Details

Attachments

(1 file)

The debugger and debug scopes code use AllFramesIter. Currently they skip Ion frames because IonMonkey is disabled in debug mode, but the baseline compiler will be enabled in debug mode, so AllFramesIter has to know about these frames.
Attached patch Patch (deleted) — Splinter Review
Makes AllFramesIter iterate over Ion frames. Very similar to the StackIter implementation, but this only handles scripted, non-inlined frames. For baseline jit frames we can then make AllFramesIter::taggedFramePtr return a valid frame pointer. Like StackIter, isIon means baseline-or-Ion-optimized frame, when we remove JM we can rename it to isJIT. On the baseline-jit branch I will add a new method to filter optimized frames. As far as I know these patches should cover most of the VM changes we need to support jsdbg2. Eval-in-frame and JSD will need some work, but first I want to see if this works so far, so I will deal with them later.
Attachment #701206 - Flags: review?(luke)
Comment on attachment 701206 [details] [diff] [review] Patch Great!
Attachment #701206 - Flags: review?(luke) → review+
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: