Closed
Bug 831754
Opened 12 years ago
Closed 12 years ago
IonMonkey: Add patchable call instruction
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(2 files)
|
(deleted),
patch
|
mjrosenb
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
We need this to implement breakpoints in the baseline compiler.
|
Assignee | |
Comment 1•12 years ago
|
||
Emits a MOVW, MOVT, BLX/NOP sequence and the BLX/NOP can be toggled. I tested this with some other debugging patches and it works with qemu-arm.
Attachment #703309 -
Flags: review?(mrosenberg)
|
|
Assignee | |
Comment 2•12 years ago
|
||
Attachment #703315 -
Flags: review?(dvander)
|
||
Updated•12 years ago
|
Attachment #703315 -
Flags: review?(dvander) → review+
|
||
Comment 3•12 years ago
|
||
Comment on attachment 703309 [details] [diff] [review]
Part 1: ARM
Review of attachment 703309 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/src/ion/arm/Assembler-arm.cpp
@@ +2497,5 @@
> + inst = inst->next();
> + JS_ASSERT(inst->is<InstNOP>() || inst->is<InstBLXReg>());
> +
> + if (enabled)
> + *inst = InstBLXReg(ScratchRegister, Always);
You may want to only call updateTop() when the actual instruction has been changed, since it will mostly likely involve making a rather slow syscall.
Attachment #703309 -
Flags: review?(mrosenberg) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/c7b78d418a1e
https://hg.mozilla.org/integration/mozilla-inbound/rev/ef3ed8dd4726
(In reply to Marty Rosenberg [:mjrosenb] from comment #3)
> You may want to only call updateTop() when the actual instruction has been
> changed, since it will mostly likely involve making a rather slow syscall.
OK, I changed ToggleCall to be a no-op if it doesn't change anything.
|
||
Comment 5•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c7b78d418a1e
https://hg.mozilla.org/mozilla-central/rev/ef3ed8dd4726
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in
before you can comment on or make changes to this bug.
Description
•