Closed
Bug 83196
Opened 23 years ago
Closed 23 years ago
Netscape hardwired in imapMsgs.properties
Categories
(MailNews Core :: Localization, defect, P3)
MailNews Core
Localization
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla0.9.8
People
(Reporter: nhottanscp, Assigned: ssu0262)
References
Details
(Keywords: l12y)
Attachments
(1 file, 4 obsolete files)
(deleted),
patch
|
mscott
:
review+
Bienvenu
:
superreview+
|
Details | Diff | Splinter Review |
Separated from bug 80838, following file contains "Mozilla" or "Netscape", make
it localizable if possible (e.g. by using "&brandShortName;").
# Containing "Mozilla"
mailnews/compose/resources/locale/en-US/composeMsgs.properties
mailnews/local/resources/locale/en-US/localMsgs.properties
# "Containing "Netscape"
mailnews/imap/resources/locale/en-US/imapMsgs.properties
Reporter | ||
Comment 1•23 years ago
|
||
Ray, please review those files and if they needs code change then reassign to
putterman.
Keywords: l12y
The bug should go to the owner of the component.
Reassigned to putterman.
Assignee: rchen → putterman
Comment 3•23 years ago
|
||
I found the Netscape reference, but I couldn't find the mozilla references using
lxr. Reassigning to ssu.
Assignee: putterman → ssu
Comment 4•23 years ago
|
||
I fixed the Mozilla references over in bug 80838. It's just imapMsgs.properties
that needs fixing, but the fix isn't trivial.
Gerv
Comment 5•23 years ago
|
||
Narrowing SUMMARY.
Summary: Mozilla and Netscape are hardwired in some mail/news DTD files → Netscape hardwired in imapMsgs.properties
Comment 6•23 years ago
|
||
Although this is now a different bug from bug 80838, I would like to politely
point out that I did some work over there removing hardcoded "Mozilla"s in time
for nsbeta1, on the understanding that some Netscape employee would reciprocate
and remove the hardcoded Netscape's at some point, preferable for 0.9.2. We are
now at 0.9.4. :-|
Gerv
Added mscott@netscape.com on the cc list.
nevermind. my patch does not work. looking for a real fix now...
Status: NEW → ASSIGNED
Comment 10•23 years ago
|
||
cleaning up nsbranch keywords. not an eMojo stopper although we'll certainly
take a fix!
Comment 11•23 years ago
|
||
<cough> I hope ssu is still planning to fix this pretty soon. I have pointed out
before in this bug why that would be the honourable thing to do.
If it's not fixed soon, I may fix it myself by changing all the instances of
"Netscape" to "Mozilla", to match the tree this code resides in.
Gerv
Assignee | ||
Comment 12•23 years ago
|
||
I'm working on it. I've been recently distracted by other higher priority bugs.
Comment 13•23 years ago
|
||
Thanks :-) I quite understand.
Gerv
Updated•23 years ago
|
Target Milestone: mozilla0.9.7 → mozilla0.9.9
Updated•23 years ago
|
Comment 16•23 years ago
|
||
moving back in.
Priority: -- → P3
Target Milestone: mozilla1.2 → mozilla0.9.8
Assignee | ||
Comment 17•23 years ago
|
||
This patch will replace the hard coded references of 'Netscape' with '%S'.
I've added localization comments to each property affected. There are no code
changes needed because I couldn't find any place (via lxr) that referenced
these property strings.
Attachment #47678 -
Attachment is obsolete: true
Assignee | ||
Comment 18•23 years ago
|
||
fixed a few typos in the comments only from patch v1.0
Attachment #62054 -
Attachment is obsolete: true
Comment 19•23 years ago
|
||
Comment on attachment 62055 [details] [diff] [review]
patch v1.2
looks good. please check with original author of this
file to ensure those (key, value) pairs are not used.
Attachment #62055 -
Flags: review+
Comment 20•23 years ago
|
||
If they aren't used, surely we should be removing them rather than fixing them?
They are just bloat otherwise.
Gerv
Assignee | ||
Comment 21•23 years ago
|
||
I'm not sure if removing them is the correct thing to do. It looks like David
might have done some of this work. David, did you work on this before?
Comment 22•23 years ago
|
||
No, I just ported over the messages from 4.x in the very early days of 6.0 - it
turned out that we didn't use some of them, because we didn't get around to
upgrading from Communicator 4.0 (or maybe we decided we wouldn't support that).
Let me know which messages you're suggesting we remove and I'll let you know if
it seems reasonable to me. If you want to remove the messages about upgrading to
imap subscription, that's fine.
Assignee | ||
Comment 23•23 years ago
|
||
The messages in question are the ones with 'Netscape' in them. Here is a list
of the ones I found:
5016=Folder creation succeeded, but Netscape was unable to subscribe the new folder.
5017=Folder deletion succeeded, but Netscape was unable to unsubscribe from the
folder.
5018=Folder move succeeded, but Netscape was unable to subscribe to the new
folder name.
5019=Folder move succeeded, but Netscape was unable to unsubscribe from the old
folder name.
5022=While trying to automatically subscribe, Netscape has found a large number
of mail folders. Please select which folders you would like subscribed.
5023=Netscape has detected that you have upgraded from a previous version of
Communicator. You will need to choose which mail folders you want subscribed.
5025=Would you like Netscape to try to automatically subscribe to all your folders?
5027=Please wait while Netscape upgrades you to use IMAP mail folder
subscriptions...
Comment 24•23 years ago
|
||
If none of those are used, go ahead and delete them.
Assignee | ||
Comment 25•23 years ago
|
||
Attachment #62055 -
Attachment is obsolete: true
Comment 26•23 years ago
|
||
I can say that this removes the messages, but I'm not qualified to say whether
it'll break anything. LXR seems to indicate that these aren't used, and if it
builds with them removed, then that should be fine.
If it builds and nothing breaks, r=gerv.
Gerv
Comment 27•23 years ago
|
||
you'll need to remove the corresponding entries from nsImapStringBundle.h to see
if things rebuild.
Comment 28•23 years ago
|
||
Are you sure that no JS uses them?
Comment 29•23 years ago
|
||
I searched for the @name fields - was that the wrong thing to do?
You're right - they aren't preprocessor macros. My mistake.
Gerv
Assignee | ||
Comment 30•23 years ago
|
||
This patch includes diffs to nsImapStringBundle.h and imapMsgs.properties.
Imap dir (and the main mailnews dir) builds fine with the patch (I did a
clobber build in both).
I also did a global grep in the mailnews dir for the string ids in question,
and found no other references to them.
Let me know if there's a check I have missed.
Attachment #62160 -
Attachment is obsolete: true
Comment 31•23 years ago
|
||
Comment on attachment 62401 [details] [diff] [review]
patch #2 to remove resourced strings
sr=bienvenu
Attachment #62401 -
Flags: superreview+
Comment 32•23 years ago
|
||
Comment on attachment 62401 [details] [diff] [review]
patch #2 to remove resourced strings
r=mscott
Attachment #62401 -
Flags: review+
Assignee | ||
Comment 33•23 years ago
|
||
patch checked in.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Updated•20 years ago
|
Product: MailNews → Core
Updated•16 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•