Closed
Bug 832026
Opened 12 years ago
Closed 12 years ago
Measure JSRuntime::bumpAlloc_ in the JS memory reporter.
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: n.nethercote, Assigned: n.nethercote)
Details
(Whiteboard: [MemShrink])
Attachments
(1 file)
(deleted),
patch
|
sstangl
:
review+
|
Details | Diff | Splinter Review |
We don't measure the mmaps done by JSRuntime::bumpAlloc_.
Assignee | ||
Comment 1•12 years ago
|
||
This patch measures JSRuntime::bumpAlloc_. I haven't seen it go higher than 4
KiB, but we want to have complete coverage of all the mmap calls done by
Firefox, so it's worth having just for that reason. Also, it's possible that
it could go higher in rare cases.
Attachment #703602 -
Flags: review?(sstangl)
Assignee | ||
Updated•12 years ago
|
Whiteboard: [MemShrink]
Comment 2•12 years ago
|
||
Comment on attachment 703602 [details] [diff] [review]
Measure JSRuntime::bumpAlloc_ in the JS memory reporter.
Review of attachment 703602 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/src/jscntxt.cpp
@@ +155,5 @@
> }
>
> + if (bumpAlloc_) {
> + n += bumpAlloc_->sizeOfNonHeapData();
> + }
uber-nit: no need for braces in single-line if()
Attachment #703602 -
Flags: review?(sstangl) → review+
Assignee | ||
Comment 3•12 years ago
|
||
Thanks for the fast review.
> uber-nit: no need for braces in single-line if()
Going back and forth between JS and Gecko styles is such a delight.
Assignee | ||
Comment 4•12 years ago
|
||
Comment 5•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in
before you can comment on or make changes to this bug.
Description
•