Closed
Bug 84002
Opened 23 years ago
Closed 23 years ago
Remove ExpatDTD if obsolete
Categories
(Core :: XML, defect, P2)
Core
XML
Tracking
()
VERIFIED
FIXED
mozilla0.9.3
People
(Reporter: hjtoi-bugzilla, Assigned: hjtoi-bugzilla)
Details
(Keywords: memory-footprint)
Attachments
(1 file)
(deleted),
patch
|
Details | Diff | Splinter Review |
Investigate if ExpatDTD is still used. If not, remove it from build and do cvs
remove. WellformedDTD is the one that seems to be in use right now.
Nobody uses it indeed. That will save a good chunk of code. Adding the footprint
keyword.
Also, there are functions in nsExpatTokenizer that are only used by nsExpatDTD,
and could be remove as well. For example, NS_New_Expat_Tokenizer isn't a good
function to retain because it doesn't cache the filename needed for error
reporting (c.f. "Additional Comments From rbs@maths.uq.edu.au 2001-06-02 02:28"
on bug 82332).
Keywords: footprint
Assignee | ||
Comment 2•23 years ago
|
||
Assignee | ||
Updated•23 years ago
|
Priority: -- → P2
Whiteboard: [fixinhand]
Target Milestone: --- → mozilla0.9.3
What about also changing the semantics of the constructor in nsExpatTokenizer.h
so that the URL is not set to null by default: this way, people won't be tempted
to |new nsExpatTokenizer()|.
- nsExpatTokenizer(nsString* aURL = nsnull);
+ nsExpatTokenizer(nsString* aURL);
The savings introduced by the changes look good to me. r=rbs.
Whiteboard: [fixinhand] → [fixinhand] r=rbs
Assignee | ||
Comment 4•23 years ago
|
||
nsXMLDocument.cpp includes nsExpatDTD.h, the include can be safely removed.
Comment 5•23 years ago
|
||
sr=jst
Assignee | ||
Comment 6•23 years ago
|
||
Fixed.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Whiteboard: [fixinhand] r=rbs
You need to log in
before you can comment on or make changes to this bug.
Description
•