Closed Bug 84344 Opened 23 years ago Closed 23 years ago

Need ability to defer skin switch till restart

Categories

(Core Graveyard :: Skinability, defect, P1)

x86
Other
defect

Tracking

(Not tracked)

VERIFIED FIXED
mozilla0.9.2

People

(Reporter: vishy, Assigned: bugs)

Details

(Whiteboard: patch ready, have r/sr/a critical for 0.9.2)

Attachments

(1 file)

Since theme switching is still not entirely bug free ( :-) ), we would like to add the capability (perhaps under control of a hidden pref), to defer the skin switch until the next restart. That way, dataloss issues in compose/im/ms compose windows go away, and users never see in-betweem UI (i.e. mixture of 2 themes).
Keywords: nsbeta1+
Priority: -- → P1
Whiteboard: 3 days, eta 6/15
Target Milestone: --- → mozilla0.9.2
related: Bug 81715
->skinability?
Assignee: pchen → ben
Component: XP Apps → Skinability
QA Contact: sairuh → pmac
This should only be done for Netscape RTM. This should not be checked in to Mozilla.
nav triage team: Hyatt, this will be checked onto the mozilla0.9.2 branch, not the trunk
Ok, cool.
pchen: >Hyatt, this will be checked onto the mozilla0.9.2 branch, not the trunk and status: >3 days, eta 6/15 how can the eta be 6/15 if we don't branch moz0.9.2 untill 6/26? I don't think that is a reasonable eta date based on the above two comments, right?
r e l a x I think it's more of a guideline as to when the code will be sitting in my source tree ready for the Powers That Be to say "check 'er in, Ben!"
Sorry, due to exams there's been a little delay on this. I estimate 1.5 days. ETA 6/20. Fix plan: - Modify the theme panel/menu to set a pref with the current theme name when a switch occurs, and notify the user that changes will only take effect on restart. - During startup, check for the pref and switch.
Status: NEW → ASSIGNED
Whiteboard: 3 days, eta 6/15 → 1.5 days, eta 6/20
Whiteboard: 1.5 days, eta 6/20 → 1.5 days, eta 6/20, going on branch only.
ccing Rudman to get a suggestion for the wording of this new skin switching dialog. Needs to inform user that the Theme switch will happen after the application is quit and relaunched.
Ben - is this ETA still valid, are you going to have the patch ready today (even though it is to be landed after the branch).
Attached patch fix bug (deleted) — Splinter Review
Where will the text appear? In a separate dialog, and not in the Prefs panel itself? Suggested text: "You must restart Netscape 6 for your theme changes to take effect." OK/Cancel buttons will be on the dialog, presumably? We use "restart" for the app, though it more typically refers to restarting the system, but I don't think we need to worry about that. "Netscape 6" (not 6.1) is used in the Prefs pane, so I used it here. We could put something on the Prefs panel itself, like, "Changes take effect when you restart Netscape 6," but the panel is looking cluttered...And the dialog is probably sufficient. But the text can be short (and not an imperative, as in the dialog) if anyone feels that we should let the user know on the prefs panel itself.
I don't believe we intend to actually have a button do the restart, so I don't expect we want any buttons other than "OK". The point is that the Theme preference is changed but you will not see it until after the app is restarted. The user will still want to save content in compose windows before restarting.
Whiteboard: 1.5 days, eta 6/20, going on branch only. → patch ready, needs r=, sr=, a=
sr=hyatt, but put "XXX We hate this!!!!" all over the code. :)
Whiteboard: patch ready, needs r=, sr=, a= → patch ready, needs r=, a=
I agree that dialog text might be nicer, but we should really spend these dev. cycles fixing the skin switching bugs ;) the "OK" only was because there's no real use for "Cancel", it's just a notification that we're lame :)
danm says 'r=danm' Per hyatt suggestion, I've removed the section for deletion of skins as this is likely to be problematic, and the button is disabled in the UI for selected skins anyway.
a=chofmann
Whiteboard: patch ready, needs r=, a= → patch ready, have r/sr/a
Fixed.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Whiteboard: patch ready, have r/sr/a → patch ready, have r/sr/a critical for 0.9.2
Verified.
Status: RESOLVED → VERIFIED
I thought this checkin was only for the 0.9.2 branch. I just installed mozilla-win32-installer-sea.exe from the directory /pub/mozilla/nightly/2001-06-25-09-trunk/ on ftp.mozilla.org and skin switching is deferred. :-( Will we get (bug-free) dynamic skin switching sometime?
Good point. I'm seeing this on 2001062504, a trunk build. What happened to "This should only be done for Netscape RTM. This should not be checked in to Mozilla." ??
Yes, I see the theme dialog shows up when switching themes. Seen on all platforms (branch build: 2001-06-27-03-09.2).
Sorry, branch build is fine, based on pchen's comments from 2001-06-06, but it should have made it into the trunk... "Hyatt, this will be checked onto the mozilla0.9.2 branch, not the trunk"
errr not should, shouldn't... shouldn't have made it into the trunk
It's definitely in trunk buildID 2001062804
I've logged a new bug 88466 requesting the fix to this bug is backed out of the trunk as per comments on 06-06.
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: