Closed
Bug 843855
Opened 12 years ago
Closed 12 years ago
1000ms delay between unlock action and beginning of the transition
Categories
(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: zbraniecki, Assigned: zbraniecki)
References
()
Details
(Whiteboard: ux-tracking)
Attachments
(1 file)
There's a 1000ms delay between the tap action on unlock screen and the beginning of the unlock transition.
Assignee | ||
Comment 1•12 years ago
|
||
url to video capture.
sequence:
- tap: 52.6
- transition begins: 53.6
Assignee | ||
Comment 2•12 years ago
|
||
400ms of that is in repaintTimeout which we hit every time on Unagi - https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/lockscreen.js#L559
300ms in transition-delay for .unlocked - https://github.com/mozilla-b2g/gaia/blob/master/apps/system/style/lockscreen/lockscreen.css#L31
Assignee | ||
Comment 3•12 years ago
|
||
unlock tapped: 0
hit timout for repaint: 484
removing locked class: 493
transition start: 935
transition end: 1435
Assignee | ||
Comment 4•12 years ago
|
||
remove:
- transition-delay
- reduce timeout (we're hitting it after 100ms without noticable difference because the transition takes 500ms anyway)
move some function post setting nextFramePaintListener
Comment on attachment 716886 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8253
The delay might be in to work around a bug.
Attachment #716886 -
Flags: review?(timdream)
Attachment #716886 -
Flags: review?(jones.chris.g)
Attachment #716886 -
Flags: review?(alive)
Comment 6•12 years ago
|
||
Comment on attachment 716886 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8253
Looks alright, but I would like Yuren to make sure of it.
Attachment #716886 -
Flags: review?(timdream)
Attachment #716886 -
Flags: review?(alive)
Attachment #716886 -
Flags: review+
Attachment #716886 -
Flags: feedback?(yurenju)
Comment 7•12 years ago
|
||
Comment on attachment 716886 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8253
looks good for me.
Attachment #716886 -
Flags: feedback?(yurenju) → feedback+
Assignee | ||
Comment 8•12 years ago
|
||
need someone to pull it
Updated•12 years ago
|
Whiteboard: u=user c=lock s=ux-most-wanted
Comment 9•12 years ago
|
||
please squash your change to 1 commit then I'll merge it to master.
Comment 10•12 years ago
|
||
This has been squashed, but I don't have merge permissions so if you can merge this :yurenju.
Comment 11•12 years ago
|
||
Merged, thanks!
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
Whiteboard: u=user c=lock s=ux-most-wanted → ux-tracking
Updated•12 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•