Closed
Bug 845841
Opened 12 years ago
Closed 12 years ago
IonMonkey: Don't optimize element read if value may be string
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla22
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
bhackett1024
:
review+
|
Details | Diff | Splinter Review |
v8-crypto has a function (bnpFromString) where an argument is either an array or a string. Currently Ion treats it as an object and this can lead to lots of bailouts.
The attached patch is a small win on inbound and makes BL+Ion faster than JM+Ion.
Attachment #719011 -
Flags: review?(bhackett1024)
|
Assignee | |
Updated•12 years ago
|
Summary: IonMonkey: Don't optimize element read/write if value may be string → IonMonkey: Don't optimize element read if value may be string
|
||
Comment 1•12 years ago
|
||
Comment on attachment 719011 [details] [diff] [review]
Patch
Hmm. If it can be a string or an array, how come getKnownClass returns non-null in elementReadIsDenseNative?
|
|
Assignee | |
Comment 2•12 years ago
|
||
(In reply to Boris Zbarsky (:bz) from comment #1)
> Hmm. If it can be a string or an array, how come getKnownClass returns
> non-null in elementReadIsDenseNative?
If getKnownClass returns non-NULL, it means the value has that class *if it's an object*. The TypeSet can still include other types.
|
|
||
Comment 3•12 years ago
|
||
Ouch. OK, will keep that in mind.
|
||
Updated•12 years ago
|
Attachment #719011 -
Flags: review?(bhackett1024) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
|
||
Comment 5•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in
before you can comment on or make changes to this bug.
Description
•