Closed Bug 850154 Opened 12 years ago Closed 12 years ago

The Find in Page bar is displayed over the URL bar

Categories

(Firefox for Android Graveyard :: General, defect)

22 Branch
ARM
Android
defect
Not set
normal

Tracking

(firefox22 verified, fennec22+)

VERIFIED FIXED
Firefox 22
Tracking Status
firefox22 --- verified
fennec 22+ ---

People

(Reporter: AdrianT, Assigned: cwiiis)

References

Details

(Keywords: regression, reproducible)

Attachments

(2 files)

Attached image screenshot (deleted) —
Nightly 22.0a1 2013-03-11 Asus EEE Transformer TF101 (Android 4.0.4) / Samsung Galaxy Tab 2 7.0 (Android 4.0.4) Steps to reproduce: 1. Load any webpage with text ( for e.g. the mozilla webpage on wikipedia) 2. Open Find in Page Expected results: The Find in Page bar overlaps the URL bar perfectly just like on phones Actual results: The bottom edge of the URL bar is still visible because the Find in page bar does not have the same height as the URL bar Note: At the moment this is only reproducible on Nightly since only there the Find in Page Bar is displayed on top of the screen although I did not find the bug where this change has been added
Uhh isn't the find in page bar supposed to be at the bottom of the screen? This may have been introduced by bug 716403.
uh, yes... I'll have a look at this.
Assignee: nobody → chrislord.net
Status: NEW → ASSIGNED
Changing the title then to reflect the underlining issue of the Find in Page bar being displayed on top of the URL bar.
Summary: [Tablet] The URL bar lower border is visible under the Find in Page bar → The Find in Page bar is displayed over the URL bar
tracking-fennec: ? → 22+
Restore the previous behaviour.
Attachment #725457 - Flags: review?(sriram)
Comment on attachment 725457 [details] [diff] [review] Align find-in-page bar to the bottom of the app Review of attachment 725457 [details] [diff] [review]: ----------------------------------------------------------------- ::: mobile/android/base/resources/layout/gecko_app.xml.in @@ +28,5 @@ > android:layout_width="fill_parent" > android:layout_height="fill_parent" > android:layout_weight="1" > + android:layout_below="@+id/toolbar_spacer" > + android:layout_above="@+id/find_in_page"> I think the idea is have the Find-in-page "over" the content. This attribute will make it resize the page and show it below it. If this is the approach we want, please remove android:layout_weight="1" @@ +42,5 @@ > > <org.mozilla.gecko.FindInPageBar android:id="@+id/find_in_page" > android:layout_width="fill_parent" > android:layout_height="wrap_content" > + android:layout_alignParentBottom="true" Just this should be fine. Could you try removing the above one?
Comment on attachment 725457 [details] [diff] [review] Align find-in-page bar to the bottom of the app Review of attachment 725457 [details] [diff] [review]: ----------------------------------------------------------------- I think I am wrong. The find-in-page shouldn't be over the content. This will work. Please remove the "layout_weight" attribute alone. r+ with that.
Attachment #725457 - Flags: review?(sriram) → review+
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 22
Version: Trunk → Firefox 22
Verified fixed on: -build: Firefox for Android 22.0a1 (2013-03-28) -device: LG Nexus 4 -OS: Android 4.2.2
Status: RESOLVED → VERIFIED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: