+++ This bug was initially created as a clone of Bug #857823 +++

Comment on attachment 733356 [details] [diff] [review] part 1 - cleanup Please forgive me. :) This is just some format cleanup of SelectionHelperUI.

Comment on attachment 733359 [details] [diff] [review] part 2 - handle DeckOffset events reposition form elements when they are obscured by the soft keyboard.

Comment on attachment 733361 [details] [diff] [review] part 3 - merge closeEditSession calls minor housekeeping, coalesce two api calls in SelectionHelperUi into one.

Comment on attachment 733365 [details] [diff] [review] part 4 - remove pointer-events: none from selection overlay The icing on the cake - remove the selection overlay event trap. There is a rollup in the parent bug of everything I've been working on. If you'd like to take it for a spin I can fire up a try build.

Comment on attachment 733359 [details] [diff] [review] part 2 - handle DeckOffset events Review of attachment 733359 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/metro/base/content/helperui/SelectionHelperUI.js @@ +817,5 @@ > + }, > + > + _onResize: function _onResize() { > + this._sendAsyncMessage("Browser:SelectionUpdate", {}); > + }, Did part of this hunk get duplicated from the previous patch? @@ +846,5 @@ > + > + _onDebugRectRequest: function _onDebugRectRequest(aMsg) { > + this.overlay.addDebugRect(aMsg.left, aMsg.top, aMsg.right, aMsg.bottom, > + aMsg.color, aMsg.fill, aMsg.id); > + }, More duplicate code.

Comment on attachment 733361 [details] [diff] [review] part 3 - merge closeEditSession calls Review of attachment 733361 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/metro/base/content/ContextCommands.js @@ +65,5 @@ > // content > if (ContextMenuUI.popupState.string) { > this.sendCommand("copy"); > > + SelectionHelperUI.closeEditSession((false, true)); Extra ((parens)) snuck in here. ::: browser/metro/base/content/helperui/SelectionHelperUI.js @@ +385,2 @@ > */ > + closeEditSession: function closeEditSession(aClearFocus, aClearSelection) { Do we ever pass aClearFocus=true anymore? If not, we could remove it. @@ +940,5 @@ > > case "ZoomChanged": > case "URLChanged": > case "MozPrecisePointer": > + this.closeEditSession((false, true)); ((and here))

Comment on attachment 733365 [details] [diff] [review] part 4 - remove pointer-events: none from selection overlay Review of attachment 733365 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/metro/theme/browser.css @@ +270,5 @@ > } > > +.selection-overlay { > + pointer-events: none; > +} Would it be reasonable to get rid of the overlay binding completely and just have the monocles directly in browser.xul? Or do we still get some use out of having an overlay?

(In reply to Matt Brubeck (:mbrubeck) from comment #12) > Comment on attachment 733359 [details] [diff] [review] > part 2 - handle DeckOffset events > > Review of attachment 733359 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: browser/metro/base/content/helperui/SelectionHelperUI.js > @@ +817,5 @@ > > + }, > > + > > + _onResize: function _onResize() { > > + this._sendAsyncMessage("Browser:SelectionUpdate", {}); > > + }, > > Did part of this hunk get duplicated from the previous patch? > > @@ +846,5 @@ > > + > > + _onDebugRectRequest: function _onDebugRectRequest(aMsg) { > > + this.overlay.addDebugRect(aMsg.left, aMsg.top, aMsg.right, aMsg.bottom, > > + aMsg.color, aMsg.fill, aMsg.id); > > + }, > > More duplicate code. Bad merge, updated.

(In reply to Matt Brubeck (:mbrubeck) from comment #13) > Comment on attachment 733361 [details] [diff] [review] > part 3 - merge closeEditSession calls > > Review of attachment 733361 [details] [diff] [review]: > ----------------------------------------------------------------- Updated per comments.

https://hg.mozilla.org/mozilla-central/rev/d33c412d2be0 https://hg.mozilla.org/mozilla-central/rev/6a67ec142bb1 https://hg.mozilla.org/mozilla-central/rev/7dd4f12137c3 https://hg.mozilla.org/mozilla-central/rev/a6225409a345