Closed
Bug 85794
Opened 23 years ago
Closed 16 years ago
pretty name default for servers is hardcoded
Categories
(SeaMonkey :: MailNews: Message Display, defect, P2)
Tracking
(Not tracked)
RESOLVED
WORKSFORME
mozilla1.2alpha
People
(Reporter: sspitzer, Unassigned)
References
()
Details
(Keywords: l12y)
Attachments
(2 files)
(deleted),
patch
|
Bienvenu
:
review-
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Bienvenu
:
review-
|
Details | Diff | Splinter Review |
looking at
http://lxr.mozilla.org/seamonkey/source/mailnews/base/util/nsMsgIncomingServer.cpp#616
we default the pretty name to be "<username> on <hostname".
" on " is hardcoded. that string should live in a string bundle.
Reporter | ||
Comment 1•23 years ago
|
||
it's a little trickier than that.
something like "%S1 on %S2" should live in a bundle (where we tell the localizer
that S1 is username and S2 is hostname.
if no username, then we just have the hostname and we don't need a format string
for that.
Comment 2•23 years ago
|
||
cleaning up nsbranch keywords. not an emojo stopper.
Updated•23 years ago
|
Updated•23 years ago
|
Target Milestone: mozilla0.9.9 → mozilla1.0
Seth, is this visible to the user? does anyone know how to bring it up?
Updated•23 years ago
|
Updated•20 years ago
|
Product: Browser → Seamonkey
Updated•20 years ago
|
Updated•20 years ago
|
Assignee: sspitzer → mail
Comment 6•19 years ago
|
||
Makes it like
<http://lxr.mozilla.org/seamonkey/source/mailnews/imap/src/nsImapIncomingServer.cpp#200>.
Attachment #196201 -
Flags: review?(bienvenu)
Comment 7•19 years ago
|
||
I think I'd prefer the full localized solution instead of going back to a@b.
Scott, what do you think?
Comment 8•19 years ago
|
||
Are we certain "<user> on <host>" is the right order in every language? Either
way, any such languages can use "%S@%S" ...
Localized patch coming in a little while.
Comment 9•19 years ago
|
||
No, we're not - see comment #1
Comment 10•19 years ago
|
||
Not quite sure about putting it in messenger.properties or the name
(accountPrettyName).
Updated•19 years ago
|
Attachment #196238 -
Flags: review?(bienvenu)
Flags: blocking-seamonkey1.1a?
Comment 11•18 years ago
|
||
Beter L12y would really be nice to have, but we won't block a release for it, even no Alpha.
bienvenu, could you really review this? It affects localization of both Thunderbird and SeaMonkey...
Flags: blocking-seamonkey1.1a? → blocking-seamonkey1.1a-
Comment 12•18 years ago
|
||
I'm much more inclined to go for the second patch than the first patch. Unfortunately, the second patch doesn't apply cleanly against the trunk, so I need to apply it by hand to test it out.
Comment 13•18 years ago
|
||
this patch didn't work for me - we always end up creating a pretty name of user@host - we might need to change the account wizard to try to get the "constructed" pretty name.
Comment 14•18 years ago
|
||
I only tried this in TB, actually - but I suspect it's the same for SM - we create accounts with the name user@host already. I'm not inclined to change that at this point. Please let me know if I'm mistaken...
Updated•16 years ago
|
Attachment #196201 -
Flags: review?(bienvenu) → review-
Comment 15•16 years ago
|
||
David, does that make attachment 196238 [details] [diff] [review] review- for you? Or is this blocked by account wizardry?
Assignee: mail → nobody
QA Contact: esther → message-display
Comment 16•16 years ago
|
||
Comment on attachment 196238 [details] [diff] [review]
localized
yes, minus. I think this bug is invalid/wfm now - we create accounts with pretty name username@host, not user on host.
Attachment #196238 -
Flags: review?(bienvenu) → review-
Comment 17•16 years ago
|
||
wfm per comment 16
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•