Closed
Bug 859077
Opened 12 years ago
Closed 12 years ago
Annotate crash reports with layer manager init failure codes
Categories
(Core Graveyard :: Widget: WinRT, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla23
People
(Reporter: jimm, Assigned: jimm)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
bbondy
:
review+
|
Details | Diff | Splinter Review |
In diagnosing the case where D3D10 Layers! D3D10 Layers+ and Initialize fails on a refresh, it would be helpful to have the HRESULT.
|
Assignee | |
Comment 1•12 years ago
|
||
|
|
Assignee | |
Comment 2•12 years ago
|
||
Attachment #734357 -
Attachment is obsolete: true
Attachment #734358 -
Flags: review?(joe)
|
|
Assignee | |
Comment 3•12 years ago
|
||
Comment on attachment 734358 [details] [diff] [review]
patch
Joe's on vacation.
Attachment #734358 -
Flags: review?(joe) → review?(netzen)
|
||
Comment 4•12 years ago
|
||
Comment on attachment 734358 [details] [diff] [review]
patch
Review of attachment 734358 [details] [diff] [review]:
-----------------------------------------------------------------
nit: But can't we just return HRESULT instead?
Attachment #734358 -
Flags: review?(netzen) → review+
|
|
||
Comment 5•12 years ago
|
||
(and update the places that call this)
|
|
Assignee | |
Comment 6•12 years ago
|
||
(In reply to Brian R. Bondy [:bbondy] from comment #4)
> Comment on attachment 734358 [details] [diff] [review]
> patch
>
> Review of attachment 734358 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> nit: But can't we just return HRESULT instead?
Yeah I can do that. I skipped it because tracking down any calls was a pain due the generic name, but I suppose a few try runs would insure I track them all down.
|
|
Assignee | |
Updated•12 years ago
|
Attachment #734358 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 7•12 years ago
|
||
Pfft. I'm not sure what I was thinking, for some reason I had it in my head that this was cross platform. :)
|
|
Assignee | |
Comment 8•12 years ago
|
||
So turns out my original guess was accurate, Initialize is inherited from a base layer interface, so I can't change the calling convention. So I'm going to stick with the original patch you approved.
|
|
Assignee | |
Updated•12 years ago
|
Attachment #734358 -
Attachment is obsolete: false
|
||
Comment 9•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
|
|
Assignee | |
Comment 10•12 years ago
|
||
This isn't showing up in the the latest crash data, which implies this has nothing to do with a failed attempt to create a d3d layer manager -
https://crash-stats.mozilla.com/report/index/a4017f80-cd48-44eb-a5bf-ae6372130424
which is odd.
|
||
Updated•10 years ago
|
OS: Windows 8 Metro → Windows 8.1
|
||
Updated•6 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•