Closed Bug 86025 Opened 23 years ago Closed 23 years ago

factor GFX into to DLLs, convert to generic component

Categories

(Core :: Layout, defect, P2)

x86
Windows 2000
defect

Tracking

()

VERIFIED FIXED
mozilla0.9.2

People

(Reporter: waterson, Assigned: waterson)

References

Details

Attachments

(1 file)

This is to support the static build. We need to turn GFX into a generic module, and break out the utility stuff (e.g., nsRect) into its own DLL. This makes windows be just like Linux.
Blocks: 81371
Status: NEW → ASSIGNED
Attached patch diff -wuN of windows GFX mods (deleted) — Splinter Review
kmcclusk, attinasi: could you two tag-team r=/sr= these changes? The details of the build system changes are outlined in 81371, but the short, sweet version of these specific changes are: - Convert GFX to a generic module. - Split GFX into two different modules, one containing Win32-specific GFX goop, the other containing XP utilities. In the soon-to-be static build, both are created as static libraries that get linked into the final executable. In the dynamic build (i.e., what we do now), gkgfx.dll gets installed in $(DIST)/bin, and contains the XP stuff that the world needs to link against (e.g., nsRect); gkgfxwin.dll is a ``proper'' XPCOM component (using the generic module stuff) that gets installed in $(DIST)/bin/components. Because I split the DLL, I needed to make several things NS_GFX, i.e. _declspec(dll[import|export]), so that gkgfxwin.dll (the new component DLL) could access them. Thanks!
Priority: -- → P2
Target Milestone: --- → mozilla0.9.2
sr=attinasi
patch looks good. nice work Chris! r=kmcclusk@netscape.com
Changes checked in with STATIC_BUILD_20010612_BRANCH landing.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Keywords: donttest
Marking verified per last comments.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: