Closed
Bug 860894
Opened 12 years ago
Closed 12 years ago
Renaming/moving an IDL file shouldn't require a clobber
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla23
People
(Reporter: reuben, Assigned: glandium)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
I tried to land bug 856358 and discovered that renaming an IDL file requires a clobber. This shouldn't be necessary.
Comment 1•12 years ago
|
||
I don't suppose you know why this requires a clobber, do you? If it's in IDL building itself, it should get fixed by bug 850380. If it's in some downstream system, we might be hosed until more things are more intelligent.
Reporter | ||
Comment 2•12 years ago
|
||
All I know is that renaming dom/interfaces/contacts/nsIDOMContactProperties.idl to nsIContactProperties.idl caused this failure:
make[6]: *** No rule to make target `/builds/slave/m-in-osx64_g-00000000000000000/build/dom/interfaces/contacts/nsIDOMContactProperties.idl', needed by `_xpidlgen/nsIDOMContactManager.xpt'. Stop.
make[6]: *** Waiting for unfinished jobs....
Comment 3•12 years ago
|
||
Well, that's interesting. I would think the missing .idl would have been removed by mddepend.pl. This is most weird.
I'm optimistic this will go away in bug 850380. Let's leave open to track just in case.
Depends on: 850380
Comment 4•12 years ago
|
||
I think this is just fallout from bug 462463:
http://mxr.mozilla.org/mozilla-central/source/config/rules.mk#1357
http://mxr.mozilla.org/mozilla-central/source/xpcom/idl-parser/typelib.py#296
The patch there didn't change typelib.py to write out extra dep lines for the input IDL files, and we're not running mddepend.pl anymore which used to fix that.
Assignee | ||
Comment 5•12 years ago
|
||
Attachment #736853 -
Flags: review?(ted)
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → mh+mozilla
Updated•12 years ago
|
Attachment #736853 -
Flags: review?(ted) → review+
Assignee | ||
Comment 6•12 years ago
|
||
Comment 7•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•