Closed
Bug 863776
Opened 12 years ago
Closed 12 years ago
Fix SMS tests caused by Bug 843511
Categories
(Firefox OS Graveyard :: Gaia::SMS, defect)
Tracking
(b2g18 fixed, b2g18-v1.0.1 fixed)
RESOLVED
FIXED
People
(Reporter: julienw, Assigned: julienw)
Details
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
borjasalguero
:
review+
|
Details | Diff | Splinter Review |
The errors are caused because I added a Mock for navigator.mozSms in new tests, and it gets picked automatically when running sms_test.js.
I'll move the failing tests done in sms_test.js to thread_ui_test.js where they'll have a better home.
Assignee | ||
Comment 1•12 years ago
|
||
* rename the desktop mock to not conflict with the unit test mock
* better cleanup in the sms_test 'unit' test
* moved some of the `ThreadUI` tests that were in `sms_test` to `thread_ui_test`
---
apps/sms/js/message_manager.js | 2 +-
apps/sms/js/sms_mock.js | 2 +-
apps/sms/js/thread_ui.js | 2 +-
apps/sms/test/unit/mock_navigatormoz_sms.js | 7 ++-
apps/sms/test/unit/mock_utils.js | 5 +-
apps/sms/test/unit/sms_test.js | 32 +++---------
apps/sms/test/unit/thread_ui_test.js | 75 ++++++++++++++++++++++++++-
7 files changed, 94 insertions(+), 31 deletions(-)
see also the PR in https://github.com/mozilla-b2g/gaia/pull/9329
I also checked that I could still run the sms app in Firefox with the "debug" profile so it seems fine to me.
Attachment #740123 -
Flags: review?(fbsc)
Assignee | ||
Comment 2•12 years ago
|
||
Fixed the lint errors that I didn't see yesterday.
https://github.com/mozilla-b2g/gaia/pull/9329 is ready, travis is green.
Attachment #740123 -
Attachment is obsolete: true
Attachment #740123 -
Flags: review?(fbsc)
Attachment #740176 -
Flags: review?(fbsc)
Comment 3•12 years ago
|
||
Taking a look!
Assignee | ||
Comment 4•12 years ago
|
||
fixed one last problem that happens when we run the test-agent after another page, as the tests were triggering window.history.back.
updated the PR https://github.com/mozilla-b2g/gaia/pull/9329 as well
Attachment #740176 -
Attachment is obsolete: true
Attachment #740176 -
Flags: review?(fbsc)
Attachment #740260 -
Flags: review?(fbsc)
Updated•12 years ago
|
Attachment #740260 -
Flags: review?(fbsc) → review+
Assignee | ||
Comment 5•12 years ago
|
||
master: 0cd9bc4755307186d2b05e11d93c463d532d604f
Assignee | ||
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 6•12 years ago
|
||
a=npotb
v1.0.1: c47ef39de04e634d847cc86b6acc616fabce69eb
status-b2g18-v1.0.1:
--- → fixed
Assignee | ||
Comment 7•12 years ago
|
||
wait that bug 857943 is uplifted before uplifting this to v1-train.
Assignee | ||
Comment 8•12 years ago
|
||
a=npotb
v1-train: 1b0c3b8ef8eb6e7c5719780a22aa0ea40c51cf5f
I think I was talking about bug 857942 in comment 7.
status-b2g18:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•