Closed Bug 863776 Opened 12 years ago Closed 12 years ago

Fix SMS tests caused by Bug 843511

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(b2g18 fixed, b2g18-v1.0.1 fixed)

RESOLVED FIXED
Tracking Status
b2g18 --- fixed
b2g18-v1.0.1 --- fixed

People

(Reporter: julienw, Assigned: julienw)

Details

Attachments

(1 file, 2 obsolete files)

The errors are caused because I added a Mock for navigator.mozSms in new tests, and it gets picked automatically when running sms_test.js. I'll move the failing tests done in sms_test.js to thread_ui_test.js where they'll have a better home.
Attached patch patch v1 (obsolete) (deleted) — Splinter Review
* rename the desktop mock to not conflict with the unit test mock * better cleanup in the sms_test 'unit' test * moved some of the `ThreadUI` tests that were in `sms_test` to `thread_ui_test` --- apps/sms/js/message_manager.js | 2 +- apps/sms/js/sms_mock.js | 2 +- apps/sms/js/thread_ui.js | 2 +- apps/sms/test/unit/mock_navigatormoz_sms.js | 7 ++- apps/sms/test/unit/mock_utils.js | 5 +- apps/sms/test/unit/sms_test.js | 32 +++--------- apps/sms/test/unit/thread_ui_test.js | 75 ++++++++++++++++++++++++++- 7 files changed, 94 insertions(+), 31 deletions(-) see also the PR in https://github.com/mozilla-b2g/gaia/pull/9329 I also checked that I could still run the sms app in Firefox with the "debug" profile so it seems fine to me.
Attachment #740123 - Flags: review?(fbsc)
Attached patch patch v2 (obsolete) (deleted) — Splinter Review
Fixed the lint errors that I didn't see yesterday. https://github.com/mozilla-b2g/gaia/pull/9329 is ready, travis is green.
Attachment #740123 - Attachment is obsolete: true
Attachment #740123 - Flags: review?(fbsc)
Attachment #740176 - Flags: review?(fbsc)
Taking a look!
Attached patch patch v3 (deleted) — Splinter Review
fixed one last problem that happens when we run the test-agent after another page, as the tests were triggering window.history.back. updated the PR https://github.com/mozilla-b2g/gaia/pull/9329 as well
Attachment #740176 - Attachment is obsolete: true
Attachment #740176 - Flags: review?(fbsc)
Attachment #740260 - Flags: review?(fbsc)
Attachment #740260 - Flags: review?(fbsc) → review+
master: 0cd9bc4755307186d2b05e11d93c463d532d604f
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
a=npotb v1.0.1: c47ef39de04e634d847cc86b6acc616fabce69eb
wait that bug 857943 is uplifted before uplifting this to v1-train.
a=npotb v1-train: 1b0c3b8ef8eb6e7c5719780a22aa0ea40c51cf5f I think I was talking about bug 857942 in comment 7.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: