Closed
Bug 86418
Opened 23 years ago
Closed 23 years ago
Duplicate code elimination
Categories
(Core :: Networking: FTP, defect, P4)
Core
Networking: FTP
Tracking
()
VERIFIED
FIXED
mozilla0.9.4
People
(Reporter: drepper, Assigned: dougt)
Details
(Keywords: memory-footprint)
Attachments
(2 files)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review |
Still reviewing netwerk/streamconv/converters/nsFTPDirListingConv.cpp. I'll
soon append a patch which eliminates some duplicated code. This not only
reduces the code size for me by 384 bytes (more than 3%) but also eases
maintenance in case some new FTP server type hasto be added.
Note that the reference to the nsCString object has to be passed because
the function nsFTPDirListingConv::AsyncConvertData later on uses the string
in a PR_LOG statement. If this statement could be removed the code would be
a bit better still. No big thing, though.
The patch looks a bit strange (due to the way the diff command works) but it's
straight forward if you look at the result.
Reporter | ||
Comment 1•23 years ago
|
||
Reporter | ||
Updated•23 years ago
|
Assignee | ||
Updated•23 years ago
|
Priority: -- → P4
Reporter | ||
Comment 4•23 years ago
|
||
The patch I attached is incomplete. I had to hand-edit the patch after I
created it (since I have made other changes) and removed too much. I'll shortly
attach the second part of the patch. Sorry.
Reporter | ||
Comment 5•23 years ago
|
||
Assignee | ||
Updated•23 years ago
|
Target Milestone: mozilla0.9.2 → mozilla0.9.3
Comment 7•23 years ago
|
||
Assignee | ||
Comment 8•23 years ago
|
||
fix checked in.
Checking in nsFTPDirListingConv.cpp;
/cvsroot/mozilla/netwerk/streamconv/converters/nsFTPDirListingConv.cpp,v <--
nsFTPDirListingConv.cpp
new revision: 1.54; previous revision: 1.53
done
Checking in nsFTPDirListingConv.h;
/cvsroot/mozilla/netwerk/streamconv/converters/nsFTPDirListingConv.h,v <--
nsFTPDirListingConv.h
new revision: 1.14; previous revision: 1.13
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•