Closed
Bug 864521
Opened 12 years ago
Closed 12 years ago
Replace Fennec's AndroidKeyEvent::KEYCODE enum with Android's AKEYCODE enum
Categories
(Firefox for Android Graveyard :: Keyboards and IME, defect)
Tracking
(firefox22 wontfix, firefox23 fixed)
RESOLVED
FIXED
Firefox 23
People
(Reporter: cpeterson, Assigned: cpeterson)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
jchen
:
review+
|
Details | Diff | Splinter Review |
As suggested in bug 842927 comment 143 and 144, replace Fennec's AndroidKeyEvent::KEYCODE enum with Android's AKEYCODE enum from #include <android/keycodes.h>. This will make Android/Gonk code sharing a little easier.
Unfortunately, Android's AKEYCODE enum is missing some recent keycodes, so we need to polyfill them for Fennec (in AndroidJavaWrappers.h).
Attachment #740495 -
Flags: review?(nchen)
|
||
Comment 1•12 years ago
|
||
Comment on attachment 740495 [details] [diff] [review]
replace-AndroidKeyEvent-with-AKEYCODE.patch
Looks good. Thanks!
Attachment #740495 -
Flags: review?(nchen) → review+
|
Assignee | |
Comment 2•12 years ago
|
||
status-firefox22:
--- → wontfix
status-firefox23:
--- → fixed
|
||
Comment 3•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•