Closed Bug 866038 Opened 12 years ago Closed 7 years ago

B2G RIL: support detect voice radio technology changes

Categories

(Firefox OS Graveyard :: RIL, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: edgar, Unassigned)

References

Details

Attachments

(2 files, 4 obsolete files)

RIL v7 introduces a new unsol command, RIL_UNSOL_VOICE_RADIO_TECH_CHANGED, to indicate the voice technology has changed. We should support this.
Assignee: nobody → echen
Summary: B2G RIL: support detect radio technology changes → B2G RIL: support detect voice radio technology changes
Attached patch Handle RIL_UNSOL_VOICE_RADIO_TECH_CHANGED, v1 (obsolete) (deleted) — Splinter Review
Attachment #754750 - Attachment is obsolete: true
Attached patch P (obsolete) (deleted) — Splinter Review
Attachment #773890 - Attachment is obsolete: true
Upload correct patch
Attachment #773892 - Attachment is obsolete: true
Wrong again, I think it's time to go home :(
Attachment #773893 - Attachment is obsolete: true
Attachment #773854 - Flags: review?(vyang)
Attachment #773894 - Flags: review?(vyang)
Comment on attachment 773854 [details] [diff] [review] Part 1: Handle RIL_UNSOL_VOICE_RADIO_TECH_CHANGED, v2 Review of attachment 773854 [details] [diff] [review]: ----------------------------------------------------------------- Maybe we should hold down for a while and develop a solid process for radio tech transition first. ::: dom/system/gonk/ril_consts.js @@ -196,3 @@ > > // Akami/Maguro specific parcels. > -this.UNSOLICITED_VOICE_RADIO_TECH_CHANGED = 1034; Please remove all Akami/Maguro specific types. They're never implemented and probably never will. ::: dom/system/gonk/ril_worker.js @@ +5590,5 @@ > + // This unsolicited response will be sent when the technology of a multi-tech > + // modem is changed, ex. switch between gsm and cdma. Currently the only known > + // multi-tech modem is emulator (qemu can support both gsm and cdma). > + // TODO: We may need to reset some data when switching between gsm and cdma > + // mode, like IMEI, ESN ... etc. And that's what we should worry about. Before it becomes a complete solution and is full tested, I don't think we need a half-made part now :(
Attachment #773854 - Flags: review?(vyang) → review-
Comment on attachment 773894 [details] [diff] [review] Part 2: Xpcshell tests for RIL_UNSOL_VOICE_RADIO_TECH_CHANGED, v1 xpcshell test case doesn't really help to ensure a well solid process in handling radio tech transition.
Attachment #773894 - Flags: review?(vyang)
Component: DOM: Device Interfaces → RIL
Product: Core → Boot2Gecko
Version: Trunk → unspecified
Unassigning myself as I am no longer working on this.
Assignee: echen → nobody
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: