Closed Bug 866065 Opened 12 years ago Closed 12 years ago

Defect - ms-windows-store:// links should not need to be opened with an application

Categories

(Firefox for Metro Graveyard :: File Handling, defect, P1)

x86_64
Windows 8.1
defect

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 24

People

(Reporter: bbondy, Assigned: bbondy)

References

Details

(Whiteboard: feature=defect c=operations u=operations p=2)

Attachments

(1 file, 1 obsolete file)

When you visit an ms-windows-store link it tries to open it with an application on Desktop and Metro Firefox. This is pretty bad because the application name displays as TWINUI. If you go ahead and select that application it opens up the windows store. If you don't then nothing happens. We should auto open up these links like Google Chrome and IE do.
Point Estimate from Brian=2.
Summary: ms-windows-store:// links should not need to be opened with an application → Defect - ms-windows-store:// links should not need to be opened with an application
Whiteboard: p=2 → feature=defect c=tbd u=tbd p=0
Component: General → File Handling
Assignee: nobody → netzen
Blocks: metrov1it7
No longer blocks: metrov1defect&change
Priority: -- → P1
QA Contact: jbecerra
Whiteboard: feature=defect c=tbd u=tbd p=0 → feature=defect c=operations u=operations p=2
Status: NEW → ASSIGNED
Attached patch Patch v1. (obsolete) (deleted) — Splinter Review
uriloader prefs to enable ms-windows-store:// links for desktop and metro browser
Attachment #748983 - Flags: review?(jmathies)
Attachment #748983 - Flags: review?(jmathies) → review?(cbiesinger)
Comment on attachment 748983 [details] [diff] [review] Patch v1. +#ifdef XP_WIN +pref("network.protocol-handler.expose.ms-windows-store", false); +#endif don't add this one, it's only needed for protocol handlers that gecko implements (applies to both pref files) r=biesi with that removed
Attachment #748983 - Flags: review?(cbiesinger) → review+
Attached patch Patch v2 - w/ review comments (deleted) — Splinter Review
Attachment #749017 - Flags: review+
Attachment #748983 - Attachment is obsolete: true
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
For testing and verification.
Flags: needinfo?(virgil.dicu)
Mozilla/5.0 (Windows NT 6.2; rv:24.0) Gecko/20130515 Firefox/24.0 Trying to verify with the build from the 15th - in desktop Nightly I can still see the TWINUI prompt when attempting to open the link. In Metro, the Store is opened directly. I'll re-try tomorrow in case this didn't land in the 15th (though it should judging by the date).
Flags: needinfo?(virgil.dicu)
Ya it should be in that build, it works for me but maybe I have some other setting saved on my machine as default handler. I'll take a look.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Hey Virgil I just tried creating a new user account. I installed a release build and the latest nightly build. The release build prompted me for TWINUI an the nightly build just launched the store. Could you try again with today's nightly once it is ready? It sounds like something was fixed but not everything base on the info you gave for the build you tried last. I'll retry on a completely different computer after you check too.
Flags: needinfo?(virgil.dicu)
I'm testing by typing ms-windows-store://hi in the URLbar by the way.
Flags: needinfo?(virgil.dicu)
Flags: needinfo?(virgil.dicu)
Can still reproduce on the build from the 16th, but works with a new profile. Double checked on 2 other computers (default/non-default Nightly, updated, new install) - so this is ok. Not exactly sure what was wrong with the profile, but this can be set to verified.
Status: REOPENED → RESOLVED
Closed: 12 years ago12 years ago
Flags: needinfo?(virgil.dicu)
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
We don't have a story for this. Specialty link handling seems like a small enough surface area to not warrant a full story.
Went through the following "Defect" for iteration #12 without any issues. Used the following build: http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-08-20-03-02-06-mozilla-central/ - Went through the original test case outlined in comment #0 with an older version of Firefox Metro and reproduced the issue - Installed the above linked build and went through the same test case once again, everything worked without any issues - Clicked on the link in comment #1 and ensured that Firefox Metro opened a new tab correctly. Selected "View in Windows Store" and the store launched without any issues or prompting the user a module message indicating another application wants to run - Went through all of the above test cases in filled view without issues
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: