To reproduce: start mail read a message hit reply All note that the compose window appears, but all fields are blank! There are no identities, the message is not pre-addressed, and the message is not quoted. Seen for the first time with today's tip build (2001-06-20-04) this seems really bad if the first time you ever see this window, it is broken!

*** Bug 87138 has been marked as a duplicate of this bug. ***

We must fix that for RTM, nominating nsbeta1.

*** Bug 87163 has been marked as a duplicate of this bug. ***

moving into 0.9.2

I am trying this on WinNT 2001-06-20-04 and not seeing this behaviour. Alec is this a Win 2000 only problem?

here is the console's message when the problem occurs: >>> Time Stamp: [ 0][ 0] - Start opening the window, message size = 0 WEBSHELL+ = 9 Disabling Quirk StyleSheet ************************************************************ * Call to xpconnect wrapped JSObject produced this error: * [Exception... "'[JavaScript Error: "gPrefInt.SavePrefFile is not a function" {file: "S:\mozilla\dist\WIN32_D.OBJ\bin\components\nsLD APPrefsService.js" line: 198}]' when calling method: [nsIFactory::createInstance]" nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_E RROR_WITH_DETAILS)" location: "JS frame :: chrome://messenger/content/messengercompose/MsgComposeCommands.js :: <TOP_LEVEL> :: line 46" data: yes] ************************************************************ JavaScript error: line 0: uncaught exception: [Exception... "Component returned failure code: 0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE) [nsIJSCID .getService]" nsresult: "0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE)" location: "JS frame :: chrome://messenger/content/messenge rcompose/MsgComposeCommands.js :: <TOP_LEVEL> :: line 46" data: no] ###!!! ASSERTION: not a container: 'nsnull == aChildList', file s:\mozilla\layout\html\base\src\nsFrame.cpp, line 344 ###!!! ASSERTION: not a container: 'nsnull == aChildList', file s:\mozilla\layout\html\base\src\nsFrame.cpp, line 344 ###!!! ASSERTION: not a container: 'nsnull == aChildList', file s:\mozilla\layout\html\base\src\nsFrame.cpp, line 344 WEBSHELL+ = 10 JavaScript strict warning: chrome://global/content/autocomplete.xml#autocomplete-result-popup.textbox (getter) line 0: reference to undefined property this.__A UTOCOMPLETE_BOX__ JavaScript strict warning: chrome://global/content/autocomplete.xml#autocomplete-result-popup.textbox (getter) line 0: reference to undefined property this.__A UTOCOMPLETE_BOX__ JavaScript strict warning: line 63: anonymous function does not always return a value JavaScript strict warning: chrome://global/content/autocomplete.xml#autocomplete.fireInit() line 1: reference to undefined property this.oninit JavaScript strict warning: chrome://global/content/autocomplete.xml#autocomplete.fireInit() line 1: reference to undefined property this.oninit Enabling Quirk StyleSheet JavaScript error: line 0: uncaught exception: [Exception... "Component returned failure code: 0x80004003 (NS_ERROR_INVALID_POINTER) [nsIObserverServi ce.AddObserver]" nsresult: "0x80004003 (NS_ERROR_INVALID_POINTER)" location: "JS frame :: chrome://messenger/content/messengercomp ose/MsgComposeCommands.js :: AddMessageComposeOfflineObserver :: line 584" data: no]

This regression has been caused by the fix for bug 79252. Potential fix: Index: MsgComposeCommands.js =================================================================== RCS file: /cvsroot/mozilla/mailnews/compose/resources/content/MsgComposeCommands.js,v retrieving revision 1.192 diff -u -2 -w -r1.192 MsgComposeCommands.js --- MsgComposeCommands.js 2001/06/22 01:12:30 1.192 +++ MsgComposeCommands.js 2001/06/22 21:57:50 @@ -44,4 +44,5 @@ //This migrates the LDAPServer Preferences from 4.x to mozilla format. +try { var LDAPPrefsService = Components.classes[ "@mozilla.org/ldapprefs-service;1"].getService(); @@ -52,4 +53,5 @@ "@mozilla.org/autocompleteSession;1?type=ldap"].createInstance(). QueryInterface(Components.interfaces.nsILDAPAutoCompleteSession); +} catch (ex) {dump ("ERROR:" + ex + "\n");} var msgCompose = null; But I rather prefer let srilatha take a look at the problem. Reassign...

*** Bug 87377 has been marked as a duplicate of this bug. ***

I think we are getting this exception because I have gPrefInt.SavePrefFile instead of gPrefInt.savePrefFile. It happens only the first time because the migration code gets executed only once. In the patch I corrected the name and also Added try catch in nsLDAPPrefsService.js Added try catch in MsgcomposeCommands.js. ducarroz can you review the patch

R=ducarroz

sr=alecf on the first file in the patch, but the second file in the patch seems wrong. You're trying to initialize the variables "ldapSession" and "LDAPPrefsService" If those exceptions are simply caught but not handled (i.e. such as returning from the function) then any place where you're saying something like LDAPPrefsService.migrate() will throw a JS error, "LDAPPrefsService is not defined"

LDAPPrefsSevice.migrate() gets called from the constructor of LDAPPrefsService(). and we are not calling any methods on it anywhere else in the file. And for ldapSession, before any method is called on it, we check if ldapSession is not null.

ok, cool sr=alecf I should add that the whole migrate() thing is kinda broken - i.e. why expose it in an IDL file if nobody ever calls it, and you're just calling it in the constructor. Seems like you're better off simply implementing nsISupports or something.. not to mention that this means the migration service sits around in RAM for the lifetime of the product, even though code in it only executes once.

Filed a bug on the migrate() bug #87660

Fix checked into the trunk.

*** Bug 87745 has been marked as a duplicate of this bug. ***

please land this on the branch, too.

Reproduced the above problem on all platforms using 2001062506 on mac,linux,win98. I created a new profile and the first time you read a message and clicking on reply all opens a blank window. verified on the following trunk builds: 2001062606 -win98, linux 20010626008 -mac, I will leave it as resolved till I verify this on branch build. Adding keyword as vbranch since this needs to be verified on branch after it gets checked in.

*** Bug 88062 has been marked as a duplicate of this bug. ***

Build 2001-06-27-03: Win2k Build 2001-06-27-03: Mac 9.1 Build 2001-06-27-06: Linux RH 7 After migrating 4.x profile, create a new message or reply to a message and sender is blank. I see the same problems as Ninoschka. And if I close it and try again it's fine. It is only the first attempt that is affected. *Please disregard these comments on bug 87377 (marked as duplicate of this bug)

pushing out. 0.9.2 is done. (querying for this string will get you the list of the 0.9.2 bugs I moved to 0.9.3)

Adding PDT+; OK to be checked into 0.9.2 branch for RTM.

Checked into the branch

Branch build 2001-07-05-03: WinMe, Mac 9.04 Branch build 2001-07-05-10: Linux RH 6.2 Verified Fixed on the branch. Scenarios tried: - Existing profiles, first new message: ok - New profile, first new message: ok - Exit/Restart, reply to a message: ok

*** Bug 93278 has been marked as a duplicate of this bug. ***