Closed
Bug 870318
Opened 12 years ago
Closed 11 years ago
Remove 'responsive.css'
Categories
(Firefox OS Graveyard :: Gaia, defect)
Firefox OS Graveyard
Gaia
Tracking
(blocking-b2g:hd+, b2g-v1.1hd unaffected)
VERIFIED
FIXED
| blocking-b2g | hd+ |
| Tracking | Status | |
|---|---|---|
| b2g-v1.1hd | --- | unaffected |
People
(Reporter: timdream, Assigned: timdream)
References
Details
(Whiteboard: [TAIPEI_FND_TRACKING])
Attachments
(1 file)
Given the fact bug 845182 has landed, Gaia should no longer try to zoom it's own UI, but rely on that instead.
Even if a hardware vendor doesn't like the ratio bug 845182 generates, it could always hard-code it in user.js.
I propose that we removed responsive.css introduced in bug 830644.
|
||
Updated•12 years ago
|
Assignee: nobody → igonzaleznicolas
|
||
Comment 1•12 years ago
|
||
Has this been done already ? responsive.css is not here in https://git.mozilla.org/?p=releases/gaia.git;a=tree;f=shared/style;h=715e1c2e5195b4feee952949578d6dd025549a80;hb=refs/heads/v1-train but it is still here in master https://git.mozilla.org/?p=releases/gaia.git;a=tree;f=shared/style;hb=refs/heads/master and in v1.0.1 https://git.mozilla.org/?p=releases/gaia.git;a=tree;f=shared/style;hb=refs/heads/v1.0.1
Not having responsive.css breaks building Gaia on v1-train.
|
|
||
Comment 2•12 years ago
|
||
Okay nevermind, this has already been reported as of bug 871210.
|
Assignee | |
Updated•12 years ago
|
Whiteboard: [TAIPEI_FND_TRACKING]
|
|
Assignee | |
Comment 3•11 years ago
|
||
We should consider this bug hd+ to prevent interference with the real multi-resolution work. Gecko will scaling the UI and set the device-pixel-ratio for us.
Blocks: 881126
blocking-b2g: --- → hd?
|
|
Assignee | |
Comment 5•11 years ago
|
||
The task was trivial and repetitive, so it's better to get a few more pair of eyes here. Feel free to remove the request if you think that's enough.
Attachment #769562 -
Flags: review?(igonzaleznicolas)
Attachment #769562 -
Flags: review?(21)
Attachment #769562 -
Flags: feedback?(rexboy)
|
|
Assignee | |
Updated•11 years ago
|
Assignee: igonzaleznicolas → timdream
|
|
||
Comment 7•11 years ago
|
||
Comment on attachment 769562 [details]
Github: https://github.com/mozilla-b2g/gaia/pull/10714
Looks great thanks Tim!
Attachment #769562 -
Flags: review?(igonzaleznicolas) → review+
|
||
Comment 8•11 years ago
|
||
Comment on attachment 769562 [details]
Github: https://github.com/mozilla-b2g/gaia/pull/10714
Looks good to me. Thanks!
Attachment #769562 -
Flags: feedback?(rexboy) → feedback+
|
|
Assignee | |
Updated•11 years ago
|
Attachment #769562 -
Flags: review?(21)
|
|
Assignee | |
Comment 9•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•11 years ago
|
status-b2g-v1.1hd:
--- → unaffected
|
||
Updated•11 years ago
|
Attachment mime type: text/plain → text/x-github-pull-request
|
||
Updated•11 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•