Closed
Bug 871639
Opened 12 years ago
Closed 11 years ago
Incorrect title when leaving editing mode while on about:home
Categories
(Firefox for Android Graveyard :: Awesomescreen, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 26
People
(Reporter: lucasr, Assigned: Margaret)
References
Details
(Whiteboard: fixed-fig)
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
wesj
:
review+
|
Details | Diff | Splinter Review |
While on about:home, tapping the AwesomeBar, entering text, then clicking back doesn't restore the title.
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → margaret.leibovic
|
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #750737 -
Flags: review?(wjohnston)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 750737 [details] [diff] [review]
patch
Review of attachment 750737 [details] [diff] [review]:
-----------------------------------------------------------------
I don't love passing boolean parameters where its not clear at a glance what they do (but I'm as guilty of it as anyone). Maybe we could create two public methods:
String cancelEdit() { return stopEditing(); }
String commitEdit() {
String url = stopEditing();
if (!TextUtils.isEmpty(url))
setTitle(url);
return url;
}
Attachment #750737 -
Flags: review?(wjohnston) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
That suggestion sounds good to me.
Attachment #750737 -
Attachment is obsolete: true
Attachment #751124 -
Flags: review?(wjohnston)
|
|
||
Updated•12 years ago
|
Attachment #751124 -
Flags: review?(wjohnston) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
Whiteboard: fixed-fig
|
||
Comment 5•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•