Closed
Bug 872834
Opened 12 years ago
Closed 11 years ago
Finish adding editing mode to browser toolbar
Categories
(Firefox for Android Graveyard :: Awesomescreen, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 26
People
(Reporter: Margaret, Assigned: Margaret)
References
Details
(Whiteboard: fixed-fig)
Attachments
(1 file)
(deleted),
patch
|
Details | Diff | Splinter Review |
Filing this as a follow-up to bug 869494 to keep track of landing the last patch in there only on fig. This way, we can just close bug 869494 when the first 3 patches land on m-c.
Assignee | ||
Comment 1•12 years ago
|
||
The last patch in bug 869494 is pretty bitrotten on fig now... I'm working on updating it now, and I can post it again for review before landing it on fig.
Assignee: nobody → margaret.leibovic
Assignee | ||
Comment 2•12 years ago
|
||
I had to do quite a bit of unbitrotting to get lucasr's patch to apply to fig. I built with the patch, and it seems to work okay enough to land on fig, but I'd appreciate a quick once-over to make sure I didn't make any big mistakes.
Because of the HomePager changes, the parts of the patch to animate showing/hiding about:home didn't apply at all, so I just decided to put on those with FIXMEs that we can fix in follow-up bugs :) Same thing for implementing filterEditingMode (lucasr already had a FIXME for that in AboutHome, but I decided to make it an even higher level FIXME, since I'm not sure what API we want to be using for that with HomePager).
Attachment #750552 -
Flags: feedback?(sriram)
Attachment #750552 -
Flags: feedback?(bnicholson)
Assignee | ||
Comment 3•12 years ago
|
||
I decided this is good enough to land, we can fix things in follow-ups:
https://hg.mozilla.org/projects/fig/rev/5d9bbd9db49f
Whiteboard: fixed-fig
Assignee | ||
Comment 4•12 years ago
|
||
Attachment #750552 -
Flags: feedback?(sriram)
Attachment #750552 -
Flags: feedback?(bnicholson)
Comment 5•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•